Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain/metrics: add a metric for lease expired time (#47730) #52932

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #47730

What problem does this PR solve?

Issue Number: close #47729

Problem Summary:
Add a metric for lease expired time.

What is changed and how it works?

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    tiup playground
    explore & edit & export ...
    import again & verify the changes ...
    image

  • No need to test

    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jack Yu <jackysp@gmail.com>
Signed-off-by: Jack Yu <jackysp@gmail.com>
Signed-off-by: Jack Yu <jackysp@gmail.com>
Signed-off-by: Jack Yu <jackysp@gmail.com>
Signed-off-by: Jack Yu <jackysp@gmail.com>
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-7.5@e406d57). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52932   +/-   ##
================================================
  Coverage               ?   72.2847%           
================================================
  Files                  ?       1410           
  Lines                  ?     411102           
  Branches               ?          0           
================================================
  Hits                   ?     297164           
  Misses                 ?      94219           
  Partials               ?      19719           
Flag Coverage Δ
unit 72.2847% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4509% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 28, 2024
@crazycs520
Copy link
Contributor

@zimulala @tangenta PTAL

Copy link

ti-chi-bot bot commented Apr 29, 2024

@crazycs520: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tema
Copy link
Contributor

Tema commented Apr 30, 2024

@jackysp @hawkingrei PTAL

Copy link

ti-chi-bot bot commented May 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-28 02:39:47.061480197 +0000 UTC m=+152140.818615762: ☑️ agreed by crazycs520.
  • 2024-05-01 14:37:26.648292317 +0000 UTC m=+454400.405427889: ☑️ agreed by cfzjywxk.

Copy link

ti-chi-bot bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 6, 2024
@Tema
Copy link
Contributor

Tema commented May 6, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit dbd8ea2 into pingcap:release-7.5 May 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. component/metrics lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants