Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add a fix control to allow generate index merge path when normal index lookup path exists (#52872) #52931

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52872

What problem does this PR solve?

Issue Number: close #52869

What changed and how does it work?

Simple change. Please see the issue and code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

如果查询有除了全表扫描以外的单索引扫描方式可以选择,优化器不会自动选择索引合并。现在可以通过 Optimizer Fix Controls 机制解除这个限制。
If the optimizer can choose the single index scan method (other than full table scan) for a query plan, the optimizer will not automatically use index merge. Now this limitation can be disabled by using the Optimizer Fix Controls.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-8.1@ac5612e). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52931   +/-   ##
================================================
  Coverage               ?   71.5982%           
================================================
  Files                  ?       1463           
  Lines                  ?     423182           
  Branches               ?          0           
================================================
  Hits                   ?     302991           
  Misses                 ?      99846           
  Partials               ?      20345           
Flag Coverage Δ
unit 71.5982% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9786% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 28, 2024
Copy link

ti-chi-bot bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-28 07:15:00.724694869 +0000 UTC m=+168654.481830441: ☑️ agreed by AilinKid.
  • 2024-04-28 07:31:15.770342033 +0000 UTC m=+169629.527477599: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit a6edc7a into pingcap:release-8.1 Apr 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants