Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: fix scope can't set different value (#52627) #52909

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52627

What problem does this PR solve?

Issue Number: close #52441

Problem Summary:

What changed and how does it work?

  1. Make tidb_service_scope can be set to different values.
  2. add target scope for each tasks

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 26, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-26 07:52:33.322103101 +0000 UTC m=+333110.062006012: ☑️ agreed by Benjamin2037.
  • 2024-04-26 07:55:54.920074676 +0000 UTC m=+333311.659977590: ☑️ agreed by ywqzzy.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 96.62921% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@e34e65f). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52909   +/-   ##
================================================
  Coverage               ?   71.6256%           
================================================
  Files                  ?       1463           
  Lines                  ?     423791           
  Branches               ?          0           
================================================
  Hits                   ?     303543           
  Misses                 ?      99919           
  Partials               ?      20329           
Flag Coverage Δ
unit 71.6256% <96.6292%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9483% <0.0000%> (?)

@easonn7
Copy link

easonn7 commented Apr 26, 2024

/approve

Copy link

ti-chi-bot bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, easonn7, Leavrth, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 28, 2024
@ywqzzy
Copy link
Contributor

ywqzzy commented Apr 28, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7d912d9 into pingcap:release-8.1 Apr 28, 2024
33 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants