Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity #52907

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Unity #52907

wants to merge 53 commits into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 26, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

 explain format='unity' select * from t1, t2 where t1.a=1 and t1.b>t2.b;

{
    "Tables": {
        "test.t1": {
            "AsName": "", 
            "Columns": {
                "test.t1.a": {
                    "NDV": 2000, 
                    "Nulls": 0, 
                    "Min": "500", 
                    "Max": "1999", 
                    "Histogram": [
                        {
                            "Lower": "500", 
                            "Upper": "505", 
                            "Count": 7
                        }, 
                        {
                            "Lower": "506", 
                            "Upper": "511", 
                            "Count": 6
                        }
                    ]
                }, 
                "test.t1.b": {
                    "NDV": 2000, 
                    "Nulls": 0, 
                    "Min": "500", 
                    "Max": "1999", 
                    "Histogram": [
                        {
                            "Lower": "500", 
                            "Upper": "505", 
                            "Count": 7
                        }, 
                        {
                            "Lower": "506", 
                            "Upper": "511", 
                            "Count": 6
                        }
                    ]
                }
            }, 
            "Indexes": {
                "test.t1.a": {
                    "NDV": 2000, 
                    "Nulls": 0
                }
            }, 
            "RealtimeRows": 2000, 
            "ModifiedRows": 0
        }, 
        "test.t2": {
            "AsName": "", 
            "Columns": {
                "test.t2.b": {
                    "NDV": 2000, 
                    "Nulls": 0, 
                    "Min": "500", 
                    "Max": "1999", 
                    "Histogram": [
                        {
                            "Lower": "500", 
                            "Upper": "505", 
                            "Count": 7
                        }, 
                        {
                            "Lower": "506", 
                            "Upper": "511", 
                            "Count": 6
                        } 
                    ]
                }
            }, 
            "Indexes": {
                "test.t2.a": {
                    "NDV": 2000, 
                    "Nulls": 0
                }
            }, 
            "RealtimeRows": 2000, 
            "ModifiedRows": 0
        }
    }, 
    "Hints": [
        "merge_join(test.t1)", 
        "use_index(test.t2, test.t2.a)", 
        "index_join(test.t1)", 
        "leading(test.t1, test.t2)", 
        "hash_join(test.t1)", 
        "leading(test.t2, test.t1)", 
        "use_index(test.t1, test.t1.a)", 
        "hash_join(test.t2)", 
        "merge_join(test.t2)", 
        "index_join(test.t2)"
    ]
}

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qw4990, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 26, 2024
Copy link

tiprow bot commented Apr 26, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented May 7, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

Copy link

ti-chi-bot bot commented May 7, 2024

@qw4990: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 6964c42 link true /test build
idc-jenkins-ci-tidb/unit-test 6964c42 link true /test unit-test
idc-jenkins-ci-tidb/check_dev 6964c42 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 6964c42 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant