Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testkit: enable infoschema v2 for realtikv test #52896

Merged
merged 5 commits into from May 8, 2024

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

Enable infoschema v2 in realtikv test

What changed and how does it work?

In the past, when I add it to CI I skipped integration, because at that time infoschema v2 can not pass all the tests.
Now I verified that and it is time to add back.

Check List

Tests

  • Unit test
  • Integration test

All those tests can run under infoschema v2:

ok      github.com/pingcap/tidb/tests/realtikvtest/addindextest1        44.062s
ok      github.com/pingcap/tidb/tests/realtikvtest/addindextest2        69.938s
ok      github.com/pingcap/tidb/tests/realtikvtest/addindextest3        19.766s
ok      github.com/pingcap/tidb/tests/realtikvtest/addindextest4        108.057s
FAIL    github.com/pingcap/tidb/tests/realtikvtest/flashbacktest        49.733s
ok      github.com/pingcap/tidb/tests/realtikvtest/brietest     48.496s
ok      github.com/pingcap/tidb/tests/realtikvtest/importintotest       97.137s
ok      github.com/pingcap/tidb/tests/realtikvtest/importintotest2      28.187s
ok      github.com/pingcap/tidb/tests/realtikvtest/importintotest3      14.667s
ok      github.com/pingcap/tidb/tests/realtikvtest/importintotest4      10.576s
ok      github.com/pingcap/tidb/tests/realtikvtest/pessimistictest      253.832s
ok      github.com/pingcap/tidb/tests/realtikvtest/pipelineddmltest     100.489s
ok      github.com/pingcap/tidb/tests/realtikvtest/sessiontest  72.250s
ok      github.com/pingcap/tidb/tests/realtikvtest/statisticstest       8.400s
ok      github.com/pingcap/tidb/tests/realtikvtest/txntest      127.225s
  • Manual test (add detailed scripts or steps below)

And integration mysql test can pass under infoschema v2

diff --git a/pkg/sessionctx/variable/tidb_vars.go b/pkg/sessionctx/variable/tidb_vars.go
index 44677d38e0..9de29b4d39 100644
--- a/pkg/sessionctx/variable/tidb_vars.go
+++ b/pkg/sessionctx/variable/tidb_vars.go
@@ -1482,7 +1482,7 @@ const (
        DefTiDBSchemaVersionCacheLimit                    = 16
        DefTiDBIdleTransactionTimeout                     = 0
        DefTiDBTxnEntrySizeLimit                          = 0
-       DefTiDBSchemaCacheSize                            = 0
+       DefTiDBSchemaCacheSize                            = 1024
        DefTiDBLowResolutionTSOUpdateInterval             = 2000
        DefDivPrecisionIncrement                          = 4
        DefTiDBDMLType                                    = "STANDARD"
cd tests/integrationtest
./run-tests.sh
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2024
Copy link

tiprow bot commented Apr 26, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5919%. Comparing base (a177111) to head (2cd14c3).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52896        +/-   ##
================================================
+ Coverage   72.4167%   74.5919%   +2.1752%     
================================================
  Files          1490       1510        +20     
  Lines        428999     440325     +11326     
================================================
+ Hits         310667     328447     +17780     
+ Misses        99059      91783      -7276     
- Partials      19273      20095       +822     
Flag Coverage Δ
integration 49.6016% <ø> (?)
unit 71.6279% <ø> (+0.3225%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 46.7407% <ø> (+5.4087%) ⬆️

@tiancaiamao
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Apr 26, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-26 05:56:55.878799427 +0000 UTC m=+326172.618702339: ☑️ agreed by GMHDBJD.
  • 2024-04-26 06:57:18.695608279 +0000 UTC m=+329795.435511192: ☑️ agreed by ywqzzy.

@tiancaiamao
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented Apr 26, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
Copy link

ti-chi-bot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiancaiamao
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented May 8, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao
Copy link
Contributor Author

/test check-dev2

Copy link

tiprow bot commented May 8, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 1a1e7b5 into pingcap:master May 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants