New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testkit: enable infoschema v2 for realtikv test #52896
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52896 +/- ##
================================================
+ Coverage 72.4167% 74.5919% +2.1752%
================================================
Files 1490 1510 +20
Lines 428999 440325 +11326
================================================
+ Hits 310667 328447 +17780
+ Misses 99059 91783 -7276
- Partials 19273 20095 +822
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test unit-test |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test check-dev2 |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check-dev2 |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev2 |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #50959
Problem Summary:
Enable infoschema v2 in realtikv test
What changed and how does it work?
In the past, when I add it to CI I skipped integration, because at that time infoschema v2 can not pass all the tests.
Now I verified that and it is time to add back.
Check List
Tests
All those tests can run under infoschema v2:
And integration mysql test can pass under infoschema v2
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.