New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topsql: set RPC interceptor immediately after a txn is activated (#51795) #52881
topsql: set RPC interceptor immediately after a txn is activated (#51795) #52881
Conversation
Signed-off-by: ekexium <eke@fastmail.com>
… for Pipelined transaction. Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #52881 +/- ##
================================================
Coverage ? 72.2213%
================================================
Files ? 1464
Lines ? 427954
Branches ? 0
================================================
Hits ? 309074
Misses ? 98709
Partials ? 20171
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, MyonKeminta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #51795
What problem does this PR solve?
Issue Number: close #52845
Problem Summary:
This is to fix the resource group tag problem found in testing of pipelined-dml. The tagger was nil for Flush requests.
What changed and how does it work?
Set resource group tagger immediately after a txn is activated so that the following Flush requests can use it.
Check List
Tests
Enable P-DML for all UTs, those that failed because of lack of resource group tag now pass.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.