Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topsql: set RPC interceptor immediately after a txn is activated (#51795) #52881

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51795

What problem does this PR solve?

Issue Number: close #52845

Problem Summary:

This is to fix the resource group tag problem found in testing of pipelined-dml. The tagger was nil for Flush requests.

What changed and how does it work?

Set resource group tagger immediately after a txn is activated so that the following Flush requests can use it.

Check List

Tests

  • Unit test: existing topsql tests are not broken.
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Enable P-DML for all UTs, those that failed because of lack of resource group tag now pass.
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

… for Pipelined transaction.

Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
Copy link
Contributor

ekexium commented Apr 25, 2024

/retest

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-8.1@6987f58). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52881   +/-   ##
================================================
  Coverage               ?   72.2213%           
================================================
  Files                  ?       1464           
  Lines                  ?     427954           
  Branches               ?          0           
================================================
  Hits                   ?     309074           
  Misses                 ?      98709           
  Partials               ?      20171           
Flag Coverage Δ
unit 72.2213% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9752% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-28 02:28:23.176037982 +0000 UTC m=+151456.933173554: ☑️ agreed by crazycs520.
  • 2024-04-29 07:31:43.954621353 +0000 UTC m=+256057.711756928: ☑️ agreed by MyonKeminta.

Copy link

ti-chi-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ekexium
Copy link
Contributor

ekexium commented Apr 29, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 474e9b2 into pingcap:release-8.1 Apr 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants