New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl,mdl: fix the issue that the table_ids overlap regex is not correct #52879
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52879 +/- ##
================================================
+ Coverage 74.4098% 75.2539% +0.8440%
================================================
Files 1490 1490
Lines 356051 429078 +73027
================================================
+ Hits 264937 322898 +57961
- Misses 71835 85879 +14044
- Partials 19279 20301 +1022
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ce0f224
to
7f267f1
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, wjhuang2016, YuJuncen, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #52758
Problem Summary:
The regexp in
mdl_view
is not correct:This SQL will return 1, because it actually matches ',1' or '2,'.
What changed and how does it work?
This PR modified the REGEXP from
,1|2,
to,(1|2),
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.