Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl,mdl: fix the issue that the table_ids overlap regex is not correct #52879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Apr 25, 2024

What problem does this PR solve?

Issue Number: close #52758

Problem Summary:

The regexp in mdl_view is not correct:

SELECT ',10,` regexp ',1|2,'

This SQL will return 1, because it actually matches ',1' or '2,'.

What changed and how does it work?

This PR modified the REGEXP from ,1|2, to ,(1|2),.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.2539%. Comparing base (788d505) to head (5eace9c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52879        +/-   ##
================================================
+ Coverage   74.4098%   75.2539%   +0.8440%     
================================================
  Files          1490       1490                
  Lines        356051     429078     +73027     
================================================
+ Hits         264937     322898     +57961     
- Misses        71835      85879     +14044     
- Partials      19279      20301      +1022     
Flag Coverage Δ
integration 50.5348% <16.6666%> (?)
unit 71.2355% <50.0000%> (-1.9369%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 61.0910% <ø> (+18.2025%) ⬆️

@YangKeao
Copy link
Member Author

/retest

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Apr 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-25 07:39:27.18813874 +0000 UTC m=+245923.928041652: ☑️ agreed by wjhuang2016.
  • 2024-04-25 11:42:55.129744248 +0000 UTC m=+260531.869647160: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
Copy link

ti-chi-bot bot commented Apr 26, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@easonn7
Copy link

easonn7 commented May 8, 2024

/approve

Copy link

ti-chi-bot bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, wjhuang2016, YuJuncen, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGEXP together with CONCAT(..REPLACE..) might return unexpected result
5 participants