Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TestClearCache #52279

Merged
merged 1 commit into from Apr 1, 2024
Merged

test: fix TestClearCache #52279

merged 1 commit into from Apr 1, 2024

Conversation

zxc111
Copy link
Contributor

@zxc111 zxc111 commented Apr 1, 2024

What problem does this PR solve?

Issue Number: close #52123 #51671

Problem Summary:
TestClearCache get wrong result

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

ti-chi-bot bot commented Apr 1, 2024

Welcome @zxc111!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

Copy link

ti-chi-bot bot commented Apr 1, 2024

Hi @zxc111. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2024
Copy link

tiprow bot commented Apr 1, 2024

Hi @zxc111. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

Copy link

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 07:41:12.805669866 +0000 UTC m=+256934.333210404: ☑️ agreed by 3pointer.
  • 2024-04-01 07:41:31.446601525 +0000 UTC m=+256952.974142072: ☑️ agreed by hawkingrei.

@lance6716
Copy link
Contributor

/check-issue-triage-complete

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Merging #52279 (836081d) into master (db0d581) will increase coverage by 2.0813%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52279        +/-   ##
================================================
+ Coverage   70.7391%   72.8204%   +2.0813%     
================================================
  Files          1491       1491                
  Lines        440448     440486        +38     
================================================
+ Hits         311569     320764      +9195     
+ Misses       109378      99586      -9792     
- Partials      19501      20136       +635     
Flag Coverage Δ
integration 48.7115% <ø> (?)
unit 70.4783% <ø> (-0.0858%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4602% <ø> (+5.6476%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit c9a250a into pingcap:master Apr 1, 2024
31 checks passed
imalasong pushed a commit to imalasong/tidb that referenced this pull request Apr 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-52279-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-52279-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52915.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #52916.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52917.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 26, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestClearCache
7 participants