*: Keep the auto id allocator for single table renames | tidb-test=pr/2230

[mjonss]

Fix for concurrent auto_id usage during rename table.

What problem does this PR solve?

Issue Number: close #46904

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mjonss]

/test all

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #47892 (e7e9505) into master (ac20c56) will increase coverage by 0.9341%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47892        +/-   ##
================================================
+ Coverage   71.0545%   71.9886%   +0.9341%     
================================================
  Files          1368       1461        +93     
  Lines        402073     453349     +51276     
================================================
+ Hits         285691     326360     +40669     
- Misses        96510     107545     +11035     
+ Partials      19872      19444       -428     

Flag	Coverage Δ
integration	43.8494% <85.7142%> (?)
unit	71.7777% <89.2857%> (+0.7232%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9294% <ø> (-0.0369%)	⬇️
parser	∅ <ø> (∅)
br	46.9247% <ø> (-6.0264%)	⬇️

[mjonss]

/test all

[tiprow]

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mjonss]

/test all

[tiprow]

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hawkingrei]

/ok-to-test

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-11-02 08:46:42.004560625 +0000 UTC m=+3115599.591670791: ☑️ agreed by tiancaiamao.
• 2023-11-02 09:18:17.032571029 +0000 UTC m=+3117494.619681173: ☑️ agreed by YangKeao.

[mjonss]

@tangenta Could you ptal? I'm missing approval from ddl/meta/infoschema owners :)

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, tiancaiamao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YangKeao,tangenta,tiancaiamao]
• pkg/ddl/OWNERS [tangenta]
• pkg/infoschema/OWNERS [tangenta]
• pkg/meta/OWNERS [tangenta]
• pkg/parser/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hawkingrei]

/test all

[mjonss]

/retest

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.3: #49293.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.4: #49294.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #49295.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #49296.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #49297.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #49298.