Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Video data type field getter throws exception on poster image wi… #16972

Merged
merged 1 commit into from May 24, 2024
Merged

Fix: Video data type field getter throws exception on poster image wi… #16972

merged 1 commit into from May 24, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Apr 21, 2024

…thin related videos when using blocks

Changes in this pull request

Resolves #16963

Additional info

Fix also errors, when related video is removed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2024 •
edited by mcop1

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@blankse blankse mentioned this pull request Apr 21, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 21, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

@mcop1 mcop1 self-assigned this May 3, 2024
@mcop1 mcop1 added the Bug label May 3, 2024
@blankse blankse changed the base branch from 11.x to 11.2 May 17, 2024 08:44
@jcalifice-basecom
Copy link

Nice work! Thank you! :)

@mcop1 mcop1 added this to the 11.2.4 milestone May 24, 2024
@mcop1
Copy link
Contributor

mcop1 commented May 24, 2024

Thank you!

@mcop1 mcop1 merged commit 066bdc4 into pimcore:11.2 May 24, 2024
20 checks passed
@blankse blankse deleted the fix_data_video branch May 24, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mcop1 mcop1

Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
11.2.4
Development

Successfully merging this pull request may close these issues.

[Bug]: Video data type field getter throws exception on poster image within related videos when using blocks
4 participants
@blankse @jcalifice-basecom @mcop1 @wisconaut