Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Video data type field getter throws exception on poster image within related videos when using blocks #16963

Open
jcalifice-basecom opened this issue Apr 18, 2024 · 3 comments · Fixed by #16972

Comments

@jcalifice-basecom
Copy link

Pimcore version

11.2.2

Steps to reproduce

Class definition:

  • Some Tab
    -- Block 'videos'
    --- Video field 'video'

Inside object editor:

  • Adding block element
  • Relatinge video
  • Add image asset as poster image
  • Save object
  • Reload object

Actual Behavior

'Message: Pimcore\Model\DataObject\Data\Video::getPoster(): Return value must be of type Pimcore\Model\Asset|string|int|null, Pimcore\Model\Element\ElementDescriptor returned'

Expected Behavior

Return correct type without any exception

@jcalifice-basecom jcalifice-basecom changed the title [Bug]: Video data type field getter throws Exception on related videos within blocks [Bug]: Video data type field getter throws Exception on poster image within related videos when using blocks Apr 18, 2024
@jcalifice-basecom jcalifice-basecom changed the title [Bug]: Video data type field getter throws Exception on poster image within related videos when using blocks [Bug]: Video data type field getter throws exception on poster image within related videos when using blocks Apr 18, 2024
@blankse
Copy link
Contributor

blankse commented Apr 21, 2024

@jcalifice-basecom I created a PR: #16972

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

@blankse
Copy link
Contributor

blankse commented May 24, 2024

Fixed by #16972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants