Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router events (WIP Attempt 2) #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Router events (WIP Attempt 2) #56

wants to merge 4 commits into from

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Mar 25, 2017 •
edited

See #49 for previous discussion.

I made a few other notable changes:

  • The events are now given both the request and response. I thought this would be useful if someone wanted to use the response status code in their logging or stats.
  • I added the bubbling that was talked about, but obviously only for the two events now implemented

NOTE: if we decide to move forward with this PR then I can clean up the git history.

hacksparrow and others added 3 commits November 10, 2016 15:01
@hacksparrow
Add Router events
79f8afa 
The following events were added:

1. `handlestart` - emitted when the router starts to handle the
router stack.
2. `layer` - emitted when a layer is macthed by the router. It
returns the matched layer.
3. `handleend` - emitted when the router has completed handling
the router stack.

I am sure very sure about the name of the events, feedback are
most welcome.
@wesleytodd
removed handlestart and handleend, added bubbling layerstart and laye…
c7babd6 
…rend events
@wesleytodd
Merge remote-tracking branch 'upstream/master' into router-events
1a79bd1
@wesleytodd wesleytodd mentioned this pull request Mar 25, 2017
Closed
@wesleytodd wesleytodd mentioned this pull request Nov 22, 2017
Closed
@wangfengming wangfengming mentioned this pull request Dec 20, 2017
Closed
@wesleytodd wesleytodd mentioned this pull request Feb 22, 2019
Closed
@dougwilson dougwilson force-pushed the master branch 2 times, most recently from 7e90c9e to 8643ec6 Compare May 19, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
express-v5 ideas pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wesleytodd @dougwilson @hacksparrow