Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add node versions from 17 to 22 #303

Closed

Conversation

inigomarquinez
Copy link
Contributor

This PR adds node versions from 17 to 22 to the CI so the tests are run for all the different nodejs versions apart from version 16.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (28a5b27) to head (31d1c4c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #303   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          621       621           
  Branches       140       140           
=========================================
  Hits           621       621           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blakeembrey
Copy link
Member

Why is this useful? The library doesn’t use any node.js features so testing every version seems like overkill. And I’ll have to manually increment the latest version now?

@inigomarquinez
Copy link
Contributor Author

Why is this useful? The library doesn’t use any node.js features so testing every version seems like overkill. And I’ll have to manually increment the latest version now?

I thought this modification would be convenient for consistency with other repositories in the organisation, in which the ci runs on an array of node versions from the original to the latest active one (see this or this), so that you can easily verify that there is no problem with any of the nodejs versions.

Anyway, feel free to discard the PR if you don't find it interesting.

@blakeembrey
Copy link
Member

Happy to accept all the other version bumps, but I'd prefer to keep the node.js versions as-is - min version + max version tests only.

@inigomarquinez inigomarquinez deleted the ci/add-node-versions branch May 16, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants