Group entity #175

zugnachpankow · 2022-06-20T13:39:41Z

I think the group entity would be at a point to be merged into master. I only ran tests that used the entity with a modified seven dwarfs script, but i also ran exploit (w/o use of group entity) and had no errors due to the implementation of the group entity in the global data structure and the base component. If any problems arise with other studies or whatsoever would be good to know early on.

Changes:

implement group entity as globally available class
enable overlapping memberships of individuals in groups via a directed network (props to @mensch72 for this idea)
adjust implementation

Adding global group entity: - Added necessary group.py files - Changed all necessary files (e.g. __init__) - Study scripts run smoothly (more testing) - So far no functionality to group (is mostly copy of social system)

Added a possible group_network logic

minor typo and some todos

had error in runner: TypeError: 'dict_keyiterator' object cannot be interpreted as an integer [...] in numpy.random.mtrand.RandomState.choice ValueError: a must be 1-dimensional or an integer File "C:\Users\bigma\PycharmProjects\pycopancore\pycopancore\model_components\exploit_social_learning\implementation\culture.py", line 42, in social_update agent_j = np.random.choice(self.acquaintance_network.neighbors(agent_i)) with (self.acquaintance_network.neighbors(agent_i)) being <dict_keyiterator object at 0x00000226F0049F90> FIX: extracting list from key with list() agent_j = np.random.choice(list(self.acquaintance_network.neighbors(agent_i)))

…_network. Error while adding group to a culture (group needs to "live" somewhere, similar to cells for individuals that then give memberships to worlds and so on.

Using an directed from Individual to Group Network to handle n to n group memberships.

…he new group entity

- Add visualisation of layered group network in run_group_test_seven_dwarfs.py - Fix minor issues

Adding global group entity: - Added necessary group.py files - Changed all necessary files (e.g. __init__) - Study scripts run smoothly (more testing) - So far no functionality to group (is mostly copy of social system)

Added a possible group_network logic

minor typo and some todos

…_network. Error while adding group to a culture (group needs to "live" somewhere, similar to cells for individuals that then give memberships to worlds and so on.

…he new group entity

- Add visualisation of layered group network in run_group_test_seven_dwarfs.py - Fix minor issues

…g world, environment and metabolism the group lives in via necessary object world that is passed in study script along with culture: M.Group(culture=culture, world=world)

…over time

zugnachpankow · 2022-08-05T10:25:30Z

Add some further test: full technical functionality should be given now

jnnsbrr · 2023-10-09T14:28:08Z

docs/framework_documentation/abstract_level/entity_types/group.rst

-  have one or several "leader" :doc:`individuals<individual>`, 
-   of which one may be the dominant leader
+-  have an "intra" group network between members :doc:`individuals<individual>`
+   (this feature is not completely implemented yet)


only describe (and explicitly) what feature is implemented and add TODO tags in the code.

jnnsbrr · 2023-10-09T14:28:27Z

docs/framework_documentation/abstract_level/entity_types/group.rst

   (which will typically interact with the network of personal acquaintance between member individuals)
+   - (this feature is not completely implemented yet)


jnnsbrr · 2023-10-09T14:28:38Z

docs/framework_documentation/abstract_level/entity_types/group.rst


-  act as the current "elite" in some :doc:`social system<social system>`
+-  act as the current "elite" in some :doc:`social system<social system>` (this feature is not implemented yet)


jnnsbrr · 2023-10-09T14:28:47Z

docs/framework_documentation/abstract_level/entity_types/group.rst


 All these relationships may be dynamic.

 Finally, a group may...

 -  be a permanent subgroup of a larger group or :doc:`social system<social system>` *by definition* 
   (rather than by coincidence, e.g., "scientists" are by definition a subgroup of the group "academics",
-   and "German workers" may be by definition a subgroup of the social system "Germany")
+   and "German workers" may be by definition a subgroup of the social system "Germany") - (this feature is not implemented yet)


jnnsbrr · 2023-10-09T14:31:03Z

pycopancore/data_model/master_data_model/group.py

@@ -0,0 +1,33 @@
+"""Master data model for group."""
+
+"""https://github.com/pik-copan/pycopancore/blob/master/docs/framework_documentation/abstract_level/entity_types/group.rst"""


do not add absolute url paths to the code.

jnnsbrr · 2023-10-09T14:34:27Z

pycopancore/model_components/base/implementation/group.py

+        self._world = None
+        self.world = world
+
+        # self._social_system = None


remove code in comments

jnnsbrr

Hey @zugnachpankow, I did not find any major problems in the code, just some minor style related things.
Fine from my side 🙂

jnnsbrr · 2023-11-09T13:03:01Z

pycopancore/model_components/base/implementation/group.py

+    """cache, depends on self.next_higher_group
+    and self.next_higher_group.higher_groups"""
+    # @property  # read-only
+    # def higher_groups(self):


delete commented out code

jnnsbrr · 2023-11-09T13:05:35Z

pycopancore/model_components/base/implementation/group.py

+        w._groups.add(self)
+        self._world = w
+
+    # @property


delete commented out code.

jnnsbrr · 2023-11-09T13:06:40Z

pycopancore/model_components/base/interface.py

+                                   readonly=True)
+    culture = ReferenceVariable("culture", "", type=Culture,
+                                readonly=True)
+    # higher_groups = SetVariable(


remove commented out code

jnnsbrr · 2023-11-09T13:07:44Z

pycopancore/model_components/seven_dwarfs/implementation/group.py

+    """Group entity type mixin implementation class."""
+
+    # standard methods:
+    # TODO: only uncomment when adding custom code!


remove commented out code.

zugnachpankow added 15 commits May 2, 2022 11:40

Added structure for group entity

d89dd45

Adding global group entity: - Added necessary group.py files - Changed all necessary files (e.g. __init__) - Study scripts run smoothly (more testing) - So far no functionality to group (is mostly copy of social system)

Update group.py

ffc4927

Added a possible group_network logic

social_system

7aebe13

typo cleanup

710242a

minor typo and some todos

Implementing Individual to Group relationships via a group_membership…

c0994c4

…_network. Error while adding group to a culture (group needs to "live" somewhere, similar to cells for individuals that then give memberships to worlds and so on.

Implement Network Solution for Group Memberships

2895209

Using an directed from Individual to Group Network to handle n to n group memberships.

Update run_groups_test_seven_dwarfs.py

9c473e1

Merge remote-tracking branch 'origin/group_entity' into group_entity

284b877

Group now gets culture and further things over being part of a world.

fbb26f6

little fix

bdeb128

run_group_test_seven_dwarfs.py now demonstrates minimum features of t…

9747ce5

…he new group entity

run_group_test_seven_dwarfs.py now demonstrates minimum features of t…

032528c

…he new group entity

- Change group from living in World to living in Culture

b3bc2c6

- Add visualisation of layered group network in run_group_test_seven_dwarfs.py - Fix minor issues

add/adjust documentation

4019e10

zugnachpankow added enhancement user story marks issues that are formulated in the style of a user story, e.g. "A model composer can..." labels Jun 20, 2022

zugnachpankow requested a review from mensch72 June 20, 2022 13:39

zugnachpankow assigned jdonges Jun 20, 2022

zugnachpankow added 11 commits June 20, 2022 16:45

Added structure for group entity

30409da

Adding global group entity: - Added necessary group.py files - Changed all necessary files (e.g. __init__) - Study scripts run smoothly (more testing) - So far no functionality to group (is mostly copy of social system)

Update group.py

03ff3a0

Added a possible group_network logic

social_system

9b4aaa9

typo cleanup

f088423

minor typo and some todos

Implementing Individual to Group relationships via a group_membership…

329ab84

…_network. Error while adding group to a culture (group needs to "live" somewhere, similar to cells for individuals that then give memberships to worlds and so on.

Group now gets culture and further things over being part of a world.

696eb74

little fix

75580f4

run_group_test_seven_dwarfs.py now demonstrates minimum features of t…

244a601

…he new group entity

run_group_test_seven_dwarfs.py now demonstrates minimum features of t…

53f58d9

…he new group entity

- Change group from living in World to living in Culture

b602e71

- Add visualisation of layered group network in run_group_test_seven_dwarfs.py - Fix minor issues

add/adjust documentation

07035ab

zugnachpankow added 3 commits June 20, 2022 17:14

Merge remote-tracking branch 'origin/group_entity' into group_entity

ae3024d

- bypassed AttributeErrors in base implementation for group by gettin…

356df4b

…g world, environment and metabolism the group lives in via necessary object world that is passed in study script along with culture: M.Group(culture=culture, world=world)

Add simple test function and plot groupmembership for a single dwarf …

76474cd

…over time

zugnachpankow closed this Aug 5, 2022

zugnachpankow reopened this Aug 5, 2022

zugnachpankow added 2 commits August 10, 2022 13:36

Make illustration study more clear

447b6b8

Make illustration study more clear

34904c6

zugnachpankow mentioned this pull request Sep 29, 2022

provide group entity #172

Open

zugnachpankow assigned jnnsbrr Oct 9, 2023

jnnsbrr reviewed Oct 9, 2023

View reviewed changes

jnnsbrr reviewed Nov 9, 2023

View reviewed changes

resolve #175

bf446bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Group entity #175

Group entity #175

zugnachpankow commented Jun 20, 2022

zugnachpankow commented Aug 5, 2022

jnnsbrr Oct 9, 2023

jnnsbrr Oct 9, 2023

jnnsbrr Oct 9, 2023

jnnsbrr Oct 9, 2023

jnnsbrr Oct 9, 2023 •

edited

jnnsbrr Oct 9, 2023

jnnsbrr left a comment

jnnsbrr Nov 9, 2023

jnnsbrr Nov 9, 2023

jnnsbrr Nov 9, 2023

jnnsbrr Nov 9, 2023

		(which will typically interact with the network of personal acquaintance between member individuals)
		- (this feature is not completely implemented yet)


		- act as the current "elite" in some :doc:`social system<social system>`
		- act as the current "elite" in some :doc:`social system<social system>` (this feature is not implemented yet)

		@@ -0,0 +1,33 @@
		"""Master data model for group."""

		"""https://github.com/pik-copan/pycopancore/blob/master/docs/framework_documentation/abstract_level/entity_types/group.rst"""

Group entity #175

Are you sure you want to change the base?

Group entity #175

Conversation

zugnachpankow commented Jun 20, 2022

zugnachpankow commented Aug 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnnsbrr Oct 9, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnnsbrr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnnsbrr Oct 9, 2023 •

edited