Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove get store inside getPoolsUser #325

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

gbonumore
Copy link
Collaborator

Description

Removed get eth from store since it is already available inside as a reactive value in order to prevent signer / provider from being undefined

@jordaniza
Copy link
Collaborator

I don't understand why this fixes the problem. The removed code looks like it should work. What was the issue with calling get(eth)?

@gbonumore
Copy link
Collaborator Author

I don't understand why this fixes the problem. The removed code looks like it should work. What was the issue with calling get(eth)?

getPoolsUser gets called when eth is not defined so destructing it throws undefined on those values while using directly those from the store are already nullchecked.
Also get(eth) is totally unnecessary since with $eth we can directly access a reactive store value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants