Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pie 482 #292

Open
wants to merge 9 commits into
base: development
Choose a base branch
from
Open

Feature/pie 482 #292

wants to merge 9 commits into from

Conversation

TotoFullStackDev
Copy link
Collaborator

Description

How to test:
from staking page, scroll down to the "rewards" component, click on your reward and check in the breakdown page if numbers/votes looks correct.

Checklist
  • Linter status: 100% pass
  • Changes don't break existing behavior
  • Test coverage hasn't decreased
Testing
Refers/Fixes

Copy link
Collaborator

@AdrianAddesso AdrianAddesso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. I have a strange behaviour as I staked during September as well, during the testing phase, so pls consider that while reviewing the points below.

  1. Your Activity -> Voting Power -> use 3 decimals for consistency
  2. When I click on Nov claimed slice, it takes me to Sep report. There should not be a September report afaik, considering the Distribution started in October.
  3. My first report 'September' shows $0 Reward Value USD.
  4. My second report 'October' shows $ 31,976.98 Reward Value USD, which I wish it were, but not correct.
  5. Slice Breakdown value does not change from one report to the other
  6. Your Participation to show only the votes done. If not, then order them by: Voted, then N/A for better visibility and change N/A to Not Voted
    Mobile
  7. Long vote names almost collide with the Voted status text
  8. DAO Revenues -> Actively Managed Treasury breaks the tot $ into two lines, one for the $ and another one for the actual number.
  9. DAO Revenues -> Product Streaming Fees breaks the tot $ into two lines, one for the $ and another one for the actual number.
  10. DAO Revenues -> Misc -> Strategies Performance Fees breaks the tot $ into two lines, one for the $ and another one for the actual number.
  11. DAO Revenues -> Misc -> Withdrawal Fees on Farming breaks the tot $ into two lines, one for the $ and another one for the actual number.
  12. DAO Revenues -> Treasury Vaults title almost collides with the tot $
  13. DAO Revenues -> Treasury Vaults-> Treasury Vaults Performance breaks the tot $ into two lines, one for the $ and another one for the actual number.

Copy link
Collaborator

@AdrianAddesso AdrianAddesso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of findings:

SOLVED

  1. Your Activity -> Voting Power -> use 3 decimals for consistency
  2. When I click on Nov claimed slice, it takes me to Sep report. There should not be a September report afaik, considering the Distribution started in October.
  3. My first report 'September' shows $0 Reward Value USD.
  4. My second report 'October' shows $ 31,976.98 Reward Value USD, which I wish it were, but not correct.

PENDING
5) [OPEN QUESTION IN JIRA] Slice Breakdown value does not change from one report to the other
6) [PENDING] Your Participation to show only the votes done. If not, then order them by: Voted, then N/A for better visibility and change N/A to Not Voted
Mobile
7) [PENDING] Long vote names almost collide with the Voted status text

Once , 5, 6 and 7 are sorted out I will proceed to approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants