Use automatic number formatting

[bitigchi]

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

1. Base your code and PRs against the repositories developmental branch.
2. Sign Off all commits as we enforce the DCO for all contributions
3. Sign all your commits as they must have verified signatures
4. File a pull request for any change that requires changes to our documentation at our documentation repo

---

What does this PR aim to accomplish?:

Uses automatic number formatting that uses system locale settings.

How does this PR accomplish the above?:

By using the appropriate internalisation API's.

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.

---

• I have read the above and my PR is ready for review. Check this box to confirm

[bitigchi]

Hmm, how to define utils.js in charts.js?

[PromoFaux]

Short answer: you don't :)

Longer answer: anything in the vendor directories are third party libraries, which we shouldn't be making changes to.

Which part has issues that would need changes in charts?

[DL6ER]

To resolve these CI warnings, check out

web/scripts/pi-hole/js/charts.js

Line 8 in f79a404

/* global upstreams */

and make this something like

/* global upstreams,utils */

[PromoFaux]

Ah, apologies - ignore my comment. I made it without looking at the files changed, I didn't realise we also had a script named charts.js outside of the vendor library!

[bitigchi]

I think this will probably cover many things, and will make it easier to spot missed ones.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[PromoFaux]

@bitigchi please fix merge conflicts

[bitigchi]

Hi, I won't be able to return to this for a while, I am sorry (burnt out totally). In the meantime, if someone wants to fix this, I'd really appreciate...

[github-actions]

Existing merge conflicts have not been addressed. This PR is considered abandoned.