Bump xo from 0.56.0 to 0.57.0 #2951
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/development-v6/xo-0.57.0
branch
from
5035e8e
to
f4210bc
Compare
Bumps [xo](https://github.com/xojs/xo) from 0.56.0 to 0.57.0. - [Release notes](https://github.com/xojs/xo/releases) - [Commits](xojs/xo@v0.56.0...v0.57.0) --- updated-dependencies: - dependency-name: xo dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/development-v6/xo-0.57.0
branch
from
f4210bc
to
0214785
Compare
|
It's failing here: https://eslint.org/docs/latest/rules/prefer-object-has-own I kept the first, but disabled the second because I think it makes the code much harder to read (esp. if it is enforced on |
Signed-off-by: Christian König <ckoenig@posteo.de>
|
Re-requesting review due to the rule change. |
There was a problem hiding this comment.
I'm not sure this is a good change: Major browsers did not support the replacement in 2021/22 (Chrome as of 93 = August 2021, Firefox as of 92 = September 2021, Safari as of 15.4 = March 2022).
Yes, ancient browsers is not what we really want to support but I'm wondering if this would needlessly kill support especially for mobile devices that stopped receiving updates?
I think this deserves some extra discussion, also whether we may want to officially define the minimum version we expect to work and use something like browser-detect to show a warning on the web interface in case we assume the browser is to old. This to avoid users simply seeing some features (or the entire site) broken without getting a clue that it is a simply my-browser-is-too-old issue.
|
Interestingly, |
|
We might include |
|
A newer version of xo exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps xo from 0.56.0 to 0.57.0.
Release notes
Sourced from xo's releases.
Commits
f70e2400.57.03b9d372Require Node.js 1871857a0Update tsconfig project link (#744)80cbef4Document TypeScript extensions (#740)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)