Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Support for Configuring DHCP Subnet Mask #2800

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

UI Support for Configuring DHCP Subnet Mask #2800

wants to merge 1 commit into from

Conversation

biodigitalfish
Copy link

@biodigitalfish biodigitalfish commented Nov 2, 2023 •
edited

This PR adds the necessary UI elements and logic to support the configuration of the DHCP subnet mask from the Pi-hole admin settings, corresponding to the backend changes made in the pi-hole/pi-hole repository.

Users can now specify a subnet mask for the DHCP server directly from the web interface, providing greater flexibility and control over network configurations.

Dependency:
This PR is dependent on the changes made in PR [#5471] in the pi-hole/pi-hole repository. Please ensure that the PR in pi-hole/pi-hole is reviewed and merged before merging this one.

I am available for any questions or additional information required during the review.

Thank you for your time and consideration.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@biodigitalfish biodigitalfish mentioned this pull request Nov 2, 2023
Closed
1 task
@biodigitalfish biodigitalfish marked this pull request as draft November 2, 2023 04:57
@biodigitalfish
Add DHCPSubnetMask option WebUI
9bae2f3 
New DHCPSubnetMask option for the WebUI DHCP settings:

/settings.php
* a default value of 255.255.255.0
* new field in the DHCP form. changing the router field css so that subnet should appear alongside router field. Similar to the To: & From: IP range fields.

../savesettings.php
* Handler for DHCPSubnetMask form submission
* New positional parameter for pihole_execute call for enabledhcp function.

../func.php
* validSubnetMask function to validate format of input value

Signed-off-by: biodigitalfish <11165243+biodigitalfish@users.noreply.github.com>
@biodigitalfish biodigitalfish marked this pull request as ready for review November 2, 2023 05:30
@DL6ER
Copy link
Member

DL6ER commented Nov 4, 2023

See pi-hole/pi-hole#5471 (comment) and the related PR #2805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@biodigitalfish @DL6ER