Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to declare multiple MAC addresses #2121

Open
wants to merge 21 commits into
base: devel
Choose a base branch
from

Conversation

s482dcaw
Copy link

@s482dcaw s482dcaw commented Feb 12, 2022

Adding the ability to declare multiple MAC addresses in DHCP static entries
This is allowed by dnsmasq so the changes are only on the web interface
to allow registering the lines, and presenting them properly

Signed-off-by: s482dcaw s482dcaw@nameprivate.eu

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

{A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues}

How does this PR accomplish the above?:

{A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix}

What documentation changes (if any) are needed to support this PR?:

{A detailed list of any necessary changes}

  • {Please delete this quoted section when opening your pull request}
  • You must follow the template instructions. Failure to do so will result in your issue being closed.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.
  • Detail helps us understand an issue quicker, but please ensure it's relevant.

…ntries

Signed-off-by: s482dcaw <s482dcaw@nameprivate.eu>
@yubiuser
Copy link
Member

Follow-up of #2108

@s482dcaw
Copy link
Author

The patch also resolves the issue: #1543

@s482dcaw
Copy link
Author

I have noticed that this is stuck, is there something I need to do to take this forward?

@yubiuser
Copy link
Member

yubiuser commented Mar 15, 2022

is there something I need to do to take this forward?

Nothing you can do. None of the devs running Pi-hole as DHCP server had time for reviewing so far. We try our best, but real life is happening too.

Please be patient.

@PromoFaux
Copy link
Member

I may be able to test this at some point as I have access to a Pi-hole acting as DHCP server - however first the merge conflicts will need to be resolved

@s482dcaw
Copy link
Author

s482dcaw commented Sep 4, 2022

I have updated my local copy and resynced, but I do not know what you expect now. Shall I submit a new pull request?

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants