New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the ability to declare multiple MAC addresses #2121
base: devel
Are you sure you want to change the base?
Conversation
…ntries Signed-off-by: s482dcaw <s482dcaw@nameprivate.eu>
Follow-up of #2108 |
The patch also resolves the issue: #1543 |
I have noticed that this is stuck, is there something I need to do to take this forward? |
Nothing you can do. None of the devs running Pi-hole as DHCP server had time for reviewing so far. We try our best, but real life is happening too. Please be patient. |
I may be able to test this at some point as I have access to a Pi-hole acting as DHCP server - however first the merge conflicts will need to be resolved |
I have updated my local copy and resynced, but I do not know what you expect now. Shall I submit a new pull request? |
the same bot should be able to fix them...
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Adding the ability to declare multiple MAC addresses in DHCP static entries
This is allowed by dnsmasq so the changes are only on the web interface
to allow registering the lines, and presenting them properly
Signed-off-by: s482dcaw s482dcaw@nameprivate.eu
By submitting this pull request, I confirm the following:
{please fill any appropriate checkboxes, e.g: [X]}
{Please ensure that your pull request is for the 'devel' branch!}
git rebase
)git commit --signoff
)What does this PR aim to accomplish?:
{A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues}
How does this PR accomplish the above?:
{A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix}
What documentation changes (if any) are needed to support this PR?:
{A detailed list of any necessary changes}