Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pihole -r: Fix WebUI not resetting or installing correctly #5529

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

agent47nh
Copy link

@agent47nh agent47nh commented Dec 30, 2023


What does this PR aim to accomplish?:

This PR fixes the issue #5473

How does this PR accomplish the above?:

Added a condition that installs the web UI if it was selected for installation but was not installed before. Else, it simply attempts to reset the existing web UI repo.

Link documentation PRs if any are needed to support this PR:

No changes are required in the documentation.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review.

Signed-off-by: Naimul Hasan <23284131+agent47nh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant