Add 'edit' option to custom DNS and CNAME #4969
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Butt git@martinbutt.com
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
This PR adds an 'edit' action to the custom DNS/CNAME commands in the CLI. This allows an atomic operation to edit existing entries without knowing the previous target IP address/hostname. Without this change there are three actions required to edit an entry. One to look up the current target, one to delete that entry, and one to add the new one. This simplifies that process.
This PR adds two new functions to advanced/Scripts/webpage.sh: EditCustomDNSAddress and EditCustomCNAMERecord that delete the entry in the file and add a new one. These are different from simply deleting and adding and entry through the current CLI, as these new functions require no knowledge of the previous entry.
I can't find any existing documentation on the current CLI for custom DNS and CNAME entries. If someone points me to any, I'll be happy to update it.
By submitting this pull request, I confirm the following:
git rebase
)