Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bookworm to supported OS on Docs #984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clwgh
Copy link
Member

@clwgh clwgh commented Jan 24, 2024

What does this PR aim to accomplish?:

A user has pointed out that Pi-hole Docs does not list Bookworm as a supported OS.

This PR adds Bookworm to supported OS on Pi-hole Docs

How does this PR accomplish the above?:

Update prerequisites.md

Link documentation PRs if any are needed to support this PR:

Bookworm is confirmed as officially supported.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Chris L <github@holosys.co.uk>
@clwgh clwgh changed the title Add Bookworm to supported OS Add Bookworm to supported OS on Docs Jan 24, 2024
@pralor-bot
Copy link
Collaborator

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/supported-operating-systems-webpage-needs-updating/67842/2

@yubiuser
Copy link
Member

It seems like a netlify issue.

1:46:24 PM: Failed during stage "preparing repo": For more information, visit https://docs.netlify.com/configure-builds/troubleshooting-tips/#build-fails-with-error-128: fatal: unable to access "https://github.com/pi-hole/docs/": Failed to connect to github.com port 443: No route to host
: exit status 128

How can we trigger a re-run?

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/65b13626202dad0c1874ba04
😎 Deploy Preview https://deploy-preview-984--pihole-docs.netlify.app/main/prerequisites
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DL6ER
Copy link
Member

DL6ER commented Jan 24, 2024

I requested a re-run about two hours ago and this lead to the comment by @netlify immediately above. However, they do not appear to have really re-ran the jobs as they still show status failed 5 hours ago. I tried re-running a few times. It does seem to do something (as in: the deploy preview appeared so the build succeeded) but the new status doesn't seem to get through to Github.

grafik

@clwgh
Copy link
Member Author

clwgh commented Jan 24, 2024

Is this caused by something I've done or not done in my PR? Or is GitHub feeling poorly?

@DL6ER
Copy link
Member

DL6ER commented Jan 24, 2024

I think it is a Netlify bug not being able to clean up its mess it caused because it screwed up in a place where it usually doesn't screw up. I will try closing/re-opening the PR to see if this has any effect. Otherwise, I'd be fine with overwriting the tests using admin privileges at merge time as this is clearly not our fault.

@DL6ER DL6ER closed this Jan 24, 2024
@DL6ER DL6ER reopened this Jan 24, 2024
@DL6ER
Copy link
Member

DL6ER commented Jan 24, 2024

Well, it did restart all the tests that were fine anyway but not the netlify ones...

grafik

@rdwebdesign
Copy link
Member

rdwebdesign commented Jan 24, 2024

This seems to be an issue with Netlify (Failed to connect to github.com port 443: No route to host):

9:46:24 AM: Failed during stage "preparing repo": For more information, visit https://docs.netlify.com/configure-builds/troubleshooting-tips/#build-fails-with-error-128: fatal: unable to access "https://github.com/pi-hole/docs/": Failed to connect to github.com port 443: No route to host

Edit:

The link on the error message suggests this could be a permission issue on the repo. Did we recently change permissions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants