Suggestions for Wireguard Guide Relating to Unbound #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NittanySeaLion
force-pushed
the
release/v6.0
branch
from
ef6da5f
to
32b76ea
Compare
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/wireguard-and-unbound/66715/3 |
NittanySeaLion
force-pushed
the
release/v6.0
branch
from
0155771
to
3924863
Compare
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/err-too-many-redirects/66998/12 |
DL6ER
requested changes
Dec 18, 2023
NittanySeaLion
force-pushed
the
release/v6.0
branch
from
b33b3c3
to
9e3a28c
Compare
|
Are any other changes needed? |
yubiuser
reviewed
Mar 9, 2024
|
|
||
| But if you are using `unbound` to provide a recursive DNS server solution based on the Pi-hole's DNS guide, it may be necessary to modify the `unbound` configuration file to allow `unbound` to respond to local DNS requests. To do so, add a line `access-control: [local network subnet] allow` into `unbound`'s pi-hole.conf file and restarting unbound. For example, if your local network subnet hosting the Pi-hole device is 192.168.1.0/24: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Something here looks incorrectly rendered, but the code seems right.
There was a problem hiding this comment.
Line (186) starts with a space, breaking the code block rendering.
rdwebdesign
requested changes
Mar 9, 2024
requested changes requested changes Update docs/guides/vpn/wireguard/client.md Co-authored-by: yubiuser <ckoenig@posteo.de> Signed-off-by: NittanySeaLion <119230128+NittanySeaLion@users.noreply.github.com> Update docs/guides/vpn/wireguard/client.md Co-authored-by: yubiuser <ckoenig@posteo.de> Signed-off-by: NittanySeaLion <119230128+NittanySeaLion@users.noreply.github.com> Update docs/guides/vpn/wireguard/internal.md Co-authored-by: yubiuser <ckoenig@posteo.de> Signed-off-by: NittanySeaLion <119230128+NittanySeaLion@users.noreply.github.com> Update docs/guides/vpn/wireguard/internal.md Co-authored-by: yubiuser <ckoenig@posteo.de> Signed-off-by: NittanySeaLion <119230128+NittanySeaLion@users.noreply.github.com> Update docs/guides/vpn/wireguard/server.md Co-authored-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: NittanySeaLion <119230128+NittanySeaLion@users.noreply.github.com> Update client.md
NittanySeaLion
force-pushed
the
release/v6.0
branch
from
423deb1
to
292f36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
This PR updates some language in the WireGuard section of the Guides. It provides a fix for using unbound with WireGuard. It also suggests ufw firewall rules for the wg0 and eth0 route when clients use the tunnel to access local devices (or routing all traffic). Other improvement place warnings in positions to warn before offending activities occur and provide more details in descriptions.
By submitting this pull request, I confirm the following:
git rebase)