Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unattended install #927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SK4ndal
Copy link

@SK4ndal SK4ndal commented Sep 7, 2023

  1. Base your code and PRs against the repositories developmental branch.
    I don't see a branch named "developmental" or "development". This is based off of the master and the pull request is for the master. Please point me in the right direction if this is incorrect.

What does this PR aim to accomplish?:
It solves this issue
It documents a starting point for doing a headless install of pihole.

How does this PR accomplish the above?:

It adds a page detailing the process I used to get it working.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • [ V] I have read the above and my PR is ready for review. Check this box to confirm

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit da8d09e
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/64fa338d63ba0a00085493f6
😎 Deploy Preview https://deploy-preview-927--pihole-docs.netlify.app/guides/misc/unattended-install
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SK4ndal
Copy link
Author

SK4ndal commented Sep 7, 2023

Hey! This is my first PR for Pihole. Please provide feedback.

I would like to add more on the available variables for setupVars.conf. I tried searching through the code to see if the docker environmental variables would work for the setupVars.conf as there is some overlap but I had no success. Any pointers in that regard would be welcome.

Signed-off-by: SK4ndal <email@sk4ndal.nl>
@yubiuser
Copy link
Member

yubiuser commented Sep 14, 2023

Thanks for your PR.

I don't see a branch named "developmental" or "development". This is based off of the master and the pull request is for the master. Please point me in the right direction if this is incorrect.

This is fine. This repo does not have a development branch.


I would like to add more on the available variables for setupVars.conf. I tried searching through the code to see if the docker environmental variables would work for the setupVars.conf as there is some overlap but I had no success. Any pointers in that regard would be welcome.

Handling of ´setupVars.conf is a mess as it evolved over time. Not everything you could set in there will survive during an unattended install. The only chance you have is to go through the source and figure it out manually, there is no reference. Likely, a lot will change in regard to that file with Pi-hole v6.

__

I wonder if your PR should not be hidden under misc but in Getting Started/Installation/Unattended installation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants