Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't offer setting a static IP anymore #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jan 7, 2023

What does this PR aim to accomplish?:

This is the documentation change for pi-hole/pi-hole#5111.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@netlify
Copy link

netlify bot commented Jan 7, 2023

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 3b970d0
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/63b9de8f128a7d0009d4ef43
😎 Deploy Preview https://deploy-preview-842--pihole-docs.netlify.app/main/prerequisites
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yubiuser
Copy link
Member Author

yubiuser commented Jan 7, 2023

Setting this to "On hold" until the core PR is merged at some point in the future.

@DL6ER
Copy link
Member

DL6ER commented May 20, 2023

note that this PR is to be merged at a later point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants