Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (undocumented) advanced flag in details config output #1883

Open
wants to merge 1 commit into
base: development-v6
Choose a base branch
from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 11, 2024

What does this implement/fix?

As suggested by @yubiuser in pi-hole/web#2882 (comment)


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@rdwebdesign
Copy link
Member

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DL6ER
Copy link
Member Author

DL6ER commented Mar 16, 2024

Rebased on latest development-v6

Copy link

Conflicts have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants