Imgur upload functionality #311

gort818 · 2018-04-13T14:48:34Z

Added libsoup and json-glib so we can use the imgur api to do an HTTPS POST, and parse the json that is returned.

@phw let's keep this open as I push changes to this branch

fix formatting

Add files pertaining to imgur upload

gort818 · 2018-04-29T19:44:11Z

Added a bunch more goodies, still a lot of work to do. But the imgur upload is working, should I have a gtk text box to show the link of the file or just have it open in a web browser?

Take a look when you get a chance it is still pretty messy atm.

TODO:

~~Add error handling for the json parser.~~
Add functionality for opening in file manager
What to do with the imgur link when finished uploading.
Clean up code.

Destroy file chooser dialog after confirming save location, as it interferes with the share dialog.

Added glib error handling, code formatting and now imgur link opens in browser.

Changed spacing between buttons.

Added #if HAS_GTK_SHOW_URI_ON_WINDOW for users using gtk 3.22 and above.

gort818 · 2018-05-02T01:22:25Z

Just a side note we cannot upload webm files to imgur.
https://help.imgur.com/hc/en-us/articles/115000083326-What-files-can-I-upload-What-is-the-size-limit-
~~And for some reason I cannot get mp4 files to upload.~~
Edit: Imgur does not support mp4 uploads through their api :(

pass the file extension over to check if we can upload to imgur.

Checks for file format and deselects imgur upload option for file extentions mp4 and webm as they are not supported through the imgur upload api.

If the user used mp4 or webm print a debug message telling them it is not supported for upload to imgur.

It now centers on the parent window.

If an option is unavailable automatically select the other row and display the check image. ex. Upload to imgur option is unavailable for mp4 and webm, it automatically select the option for opening in the file manager.

cocochepeau · 2018-05-06T16:09:59Z

Hey,

Would you like giving a try to Up2Share instead (https://up2sha.re)? I’m looking for an app that can serve as a desktop client to record image/gif/videos.

We support webm/mp4/gif uploads and previews as well. The current API is behind an API token but I’m sure we can work on public endpoints easily.

Let me know what you think.

gort818 · 2018-05-09T14:38:46Z

@cocochepeau once we get this branch merged we will look into other options for uploads, thanks for the heads up!

cocochepeau · 2018-05-11T12:43:25Z

Thanks - feel free to ping me if you need anything. :)

gort818 · 2018-05-15T18:42:21Z

@phw everything seems to function well enough, I am not sure how to proceed when you get a chance can you give this a test. I am going to need some help integrating this.. not sure what is the best way yet.

gort818 · 2018-06-07T14:00:51Z

@phw Have you had any time to take a look yet?

Checks for file format and deselects imgur upload option for file extentions mp4 and webm as they are not supported through the imgur upload api.

If the user used mp4 or webm print a debug message telling them it is not supported for upload to imgur.

It now centers on the parent window.

If an option is unavailable automatically select the other row and display the check image. ex. Upload to imgur option is unavailable for mp4 and webm, it automatically select the option for opening in the file manager.

Added const variable for client id, passed the file object rather than uri, added descriptive names of rows, and hid rows if the option is not available, put the imgur upload code in seperate function, change the upload to non blocking message via soup.

gort818 · 2018-09-22T00:29:24Z

Ok now works great with meson, just need to have libsoup installed.

gort818 · 2018-10-25T00:28:22Z

@phw Love it you could take another look :)

jcarizza · 2019-04-26T17:58:41Z

Hello there! It would be a great feature, but i'm not sure if should be a built-in feature.

I'm a fan of Shutter for image capture and editing and because it lack upload to diferent servers a wrote this code that listen for changes in a folder and upload it to Dropbox. https://github.com/jcarizza/drosh/

Maybe we can make a side project that listen for new files and upload them to Imgur, Dropbox or what ever.

luzpaz · 2019-09-04T20:48:19Z

any progress on this ? would hate to see this rot

gort818 · 2019-09-04T21:05:39Z

@luzpaz it works haven't touched the code for months, haven't had anyone test it out.., give it a test drive :) waiting for @phw to take another look.

luzpaz · 2019-09-05T13:41:38Z

@gort818 i will be happy to test. Just need a hand with building it. In the README it says:

meson --prefix=/usr/local builddir
cd builddir
ninja

# Run directly from source
./peek

# Install system-wide
sudo ninja install

first question: how do i create test binary without polluting my currently installed peek app? I think this may be called an 'out of source build' right?

second question: sudo ninja install i can skip this correct ?

source: https://github.com/phw/peek#from-source

gort818 · 2019-09-06T17:48:11Z

@luzpaz Yeah just skip the install command, and just run ./peek from the build directory.

luzpaz · 2019-09-07T03:24:55Z

@gort818 I pulled your branch, I ran the following:

meson --prefix=/usr/local builddir
cd builddir
ninja

but the peek binary wasn't created.

luzpaz · 2019-09-07T03:35:34Z

[foo@foo peek]$ meson --prefix=/usr/bin builddir
The Meson build system
Version: 0.51.2
Source dir: /home/foo/Projects/peek
Build dir: /home/foo/Projects/peek/builddir
Build type: native build
Project name: peek
Project version: 1.3.1
C compiler for the host machine: cc (gcc 9.1.0 "cc (GCC) 9.1.0")
Vala compiler for the host machine: valac (valac 0.44.7)
Build machine cpu family: x86_64
Build machine cpu: x86_64
Program desktop-file-validate found: YES (/usr/bin/desktop-file-validate)
Program appstream-util found: YES (/usr/bin/appstream-util)
Program glib-compile-schemas found: YES (/usr/bin/glib-compile-schemas)
Configuring com.uploadedlobster.peek.service using configuration
Program txt2man found: YES (/usr/bin/txt2man)
Program gzip found: YES (/usr/bin/gzip)
Message: Found txt2man and gzip; man page will be built and installed
Found pkg-config: /usr/bin/pkg-config (1.6.3)
Run-time dependency gtk+-3.0 found: YES 3.24.10
Run-time dependency keybinder-3.0 found: YES 0.3.2
Run-time dependency cairo found: YES 1.17.3
Run-time dependency gio-2.0 found: YES 2.60.6
Run-time dependency glib-2.0 found: YES 2.60.6
Run-time dependency gmodule-2.0 found: YES 2.60.6
Run-time dependency libsoup-2.4 found: YES 2.66.2
Run-time dependency json-glib-1.0 found: YES 1.4.4
Message: Compiling with features for GTK >= 3.16
Message: Compiling with features for GTK >= 3.20
Message: Compiling with features for GTK >= 3.22
Configuring about.ui using configuration
Found pkg-config: /usr/bin/pkg-config (1.6.3)
Dependency gtk+-3.0 found: YES (cached)
Dependency gtk+-3.0 found: YES (cached)
Dependency gtk+-3.0 found: YES (cached)
Program build-aux/meson/postinstall.py found: YES (/home/foo/Projects/peek/build-aux/meson/postinstall.py)
Build targets in project: 13
Found ninja-1.9.0 at /usr/bin/ninja

[foo@foo peek]$ cd builddir/

[foo@foo builddir]$ ninja

[2/66] Generating peek.1.txt with a custom command.
gawk: cmd. line:58: warning: regexp escape sequence `\o' is not a known regexp operator
gawk: cmd. line:116: warning: regexp escape sequence `\,' is not a known regexp operator
gawk: cmd. line:116: warning: regexp escape sequence `\;' is not a known regexp operator
[11/66] Compiling Vala source ../tests/screen-recorder/test-cli-screen-recor...Projects/peek/src/errordomain.vala /home/foo/Projects/peek/src/utils.vala.
/home/foo/Projects/peek/src/recording/recording-area.vala:43.26-43.41: warning: Gdk.Screen.get_width has been deprecated since 3.22
/home/foo/Projects/peek/src/recording/recording-area.vala:44.27-44.43: warning: Gdk.Screen.get_height has been deprecated since 3.22
Compilation succeeded - 2 warning(s)
[14/66] Compiling Vala source ../src/vapi/config.vapi ../src/main.vala ../sr...ences-dialog.vala ../src/ui/share-dialog.vala ../src/ui/shortcut-label.vala.
../src/recording/recording-area.vala:43.26-43.41: warning: Gdk.Screen.get_width has been deprecated since 3.22
../src/recording/recording-area.vala:44.27-44.43: warning: Gdk.Screen.get_height has been deprecated since 3.22
../src/ui/application-window.vala:197.5-197.27: warning: method `Peek.Ui.ApplicationWindow.get_file' never used
    public  string get_file(){
    ^^^^^^^^^^^^^^^^^^^^^^^
../src/ui/share-dialog.vala:81.5-81.33: warning: method `Peek.Ui.ShareDialog.open_file_manager' never used
    public void open_file_manager () {
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation succeeded - 4 warning(s)
[66/66] Linking target tests/test-cli-screen-recorder.

gort818 · 2019-09-07T03:44:46Z

@luzpaz It compiled successfully . I don't remember where it puts the executable in builddir/src

luzpaz · 2019-09-07T04:16:01Z

@gort818
ok, found it. not sure why I didn't see it before. I wonder if it's from my previous installation attempts. It crashes on loading. Here is the backtrace:

Starting program: /home/foo/Projects/peek/builddir/src/peek 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[New Thread 0x7ffff291d700 (LWP 20259)]
[New Thread 0x7ffff211c700 (LWP 20260)]
[New Thread 0x7ffff1797700 (LWP 20261)]

(peek:20255): GLib-GIO-ERROR **: 00:03:38.290: Settings schema 'com.uploadedlobster.peek' is not installed

Thread 1 "peek" received signal SIGTRAP, Trace/breakpoint trap.
0x00007ffff7b644e6 in ?? () from /usr/lib/libglib-2.0.so.0
(gdb) bt
#0  0x00007ffff7b644e6 in  () at /usr/lib/libglib-2.0.so.0
#1  0x00007ffff7b58cf6 in g_log_default_handler () at /usr/lib/libglib-2.0.so.0
#2  0x00007ffff7b6471d in g_logv () at /usr/lib/libglib-2.0.so.0
#3  0x00007ffff7b5af80 in g_log () at /usr/lib/libglib-2.0.so.0
#4  0x00007ffff7d07e1d in  () at /usr/lib/libgio-2.0.so.0
#5  0x00007ffff7c599a5 in  () at /usr/lib/libgobject-2.0.so.0
#6  0x00007ffff7c5a1b9 in g_object_new_valist () at /usr/lib/libgobject-2.0.so.0
#7  0x00007ffff7c5ab2a in g_object_new () at /usr/lib/libgobject-2.0.so.0
#8  0x0000555555565e60 in peek_application_get_app_settings () at ../src/application.vala:47
#9  0x0000555555566dd3 in peek_application_register_key_bindings (self=0x5555555e7100) at ../src/application.vala:202
#10 0x00005555555661a1 in peek_application_real_startup (base=0x5555555e7100) at ../src/application.vala:103
#11 0x00007ffff7c54caa in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0
#12 0x00007ffff7c42854 in  () at /usr/lib/libgobject-2.0.so.0
#13 0x00007ffff7c4689a in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#14 0x00007ffff7c47700 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#15 0x00007ffff7d1ad91 in g_application_register () at /usr/lib/libgio-2.0.so.0
#16 0x00007ffff7d1b80c in  () at /usr/lib/libgio-2.0.so.0
#17 0x00007ffff7d1b536 in g_application_run () at /usr/lib/libgio-2.0.so.0
#18 0x0000555555565d70 in _vala_main (args=0x7fffffffd898, args_length1=1) at ../src/main.vala:27
#19 0x0000555555565db3 in main (argc=1, argv=0x7fffffffd898) at ../src/main.vala:13

Sorry

gort818 · 2019-09-07T05:33:58Z

@luzpaz ok I updated it .. should work now give it a shot :)

luzpaz · 2019-09-07T05:45:24Z

rebased and built. Still crashes:

(peek:27066): GLib-GIO-ERROR **: 01:44:11.798: Settings schema 'com.uploadedlobster.peek' is not installed

Thread 1 "peek" received signal SIGTRAP, Trace/breakpoint trap.
0x00007ffff7b644e6 in ?? () from /usr/lib/libglib-2.0.so.0
(gdb) bt
#0  0x00007ffff7b644e6 in  () at /usr/lib/libglib-2.0.so.0
#1  0x00007ffff7b58cf6 in g_log_default_handler () at /usr/lib/libglib-2.0.so.0
#2  0x00007ffff7b6471d in g_logv () at /usr/lib/libglib-2.0.so.0
#3  0x00007ffff7b5af80 in g_log () at /usr/lib/libglib-2.0.so.0
#4  0x00007ffff7d07e1d in  () at /usr/lib/libgio-2.0.so.0
#5  0x00007ffff7c599a5 in  () at /usr/lib/libgobject-2.0.so.0
#6  0x00007ffff7c5a1b9 in g_object_new_valist () at /usr/lib/libgobject-2.0.so.0
#7  0x00007ffff7c5ab2a in g_object_new () at /usr/lib/libgobject-2.0.so.0
#8  0x0000555555564da0 in peek_application_get_app_settings () at ../src/application.vala:47
#9  0x0000555555565d07 in peek_application_register_key_bindings (self=0x5555555e6100) at ../src/application.vala:198
#10 0x00005555555650d5 in peek_application_real_startup (base=0x5555555e6100) at ../src/application.vala:99
#11 0x00007ffff7c54caa in g_closure_invoke () at /usr/lib/libgobject-2.0.so.0
#12 0x00007ffff7c42854 in  () at /usr/lib/libgobject-2.0.so.0
#13 0x00007ffff7c4689a in g_signal_emit_valist () at /usr/lib/libgobject-2.0.so.0
#14 0x00007ffff7c47700 in g_signal_emit () at /usr/lib/libgobject-2.0.so.0
#15 0x00007ffff7d1ad91 in g_application_register () at /usr/lib/libgio-2.0.so.0
#16 0x00007ffff7d1b80c in  () at /usr/lib/libgio-2.0.so.0
#17 0x00007ffff7d1b536 in g_application_run () at /usr/lib/libgio-2.0.so.0
#18 0x0000555555564cb0 in _vala_main (args=0x7fffffffd898, args_length1=1) at ../src/main.vala:27
#19 0x0000555555564cf3 in main (argc=1, argv=0x7fffffffd898) at ../src/main.vala:13

gort818 · 2019-09-07T05:51:10Z

@luzpaz I should have read your error :(

(peek:27066): GLib-GIO-ERROR **: 01:44:11.798: Settings schema 'com.uploadedlobster.peek' is not installed

copy data/com.uploadedlobster.peek.gschema.xml to /usr/local/share/glib-2.0/schemas/ and then

run:

glib-compile-schemas /usr/local/share/glib-2.0/schemas/

luzpaz · 2019-09-07T05:55:34Z

I'll try tomorrow. Will report then

gort818 · 2019-09-17T00:58:14Z

@luzpaz did you give it a test?

luzpaz · 2019-09-17T16:02:42Z

Yea, tried but needed to reset my environment. Will try again in the next few days. Sorry for keeping you hanging.

luzpaz · 2019-09-24T12:25:15Z

@phw do you mind also testing this ?

luzpaz · 2019-10-11T11:53:10Z

@phw ping

gort818 added 8 commits April 12, 2018 22:23

Add libsoup and json-glib pkgs

0c4eeb4

Update CMakeLists.txt

d962cf3

fix formatting

Add new files to cmake

c5ba2fb

Add files pertaining to imgur upload

Add ui for share dialog

ea6c9a9

Add code for share dialog window

1328aa4

Add share dialog instance

83fd79b

Add share dialog ui to resources

1deb39c

Rename share dialog file

9465011

gort818 added 5 commits April 30, 2018 18:13

Change required gtk version to 3.14

ea3ee1c

Destroy file chooser dialog after confirming save location

87128ee

Destroy file chooser dialog after confirming save location, as it interferes with the share dialog.

Add error handling, code formatting

62d5030

Added glib error handling, code formatting and now imgur link opens in browser.

Small ui changes

6e0bba7

Changed spacing between buttons.

Add preprocesser for gtk 3.22

59625f4

Added #if HAS_GTK_SHOW_URI_ON_WINDOW for users using gtk 3.22 and above.

gort818 added 10 commits May 1, 2018 18:54

Pass file extention to share dialog

d5b1bf7

pass the file extension over to check if we can upload to imgur.

Check for file format

c6768e5

Checks for file format and deselects imgur upload option for file extentions mp4 and webm as they are not supported through the imgur upload api.

Wrong file

853d91d

wrong file

9495360

Check for file format

e9576c6

Checks for file format and deselects imgur upload option for file extentions mp4 and webm as they are not supported through the imgur upload api.

Check for file format

5e96ae5

Checks for file format and deselects imgur upload option for file extentions mp4 and webm as they are not supported through the imgur upload api.

add debug message.

686d640

If the user used mp4 or webm print a debug message telling them it is not supported for upload to imgur.

Change positon of share dialog window

465e5ce

It now centers on the parent window.

Close the share dialog after uploading image.

dd0fee9

Fix selection boxes

97c3253

If an option is unavailable automatically select the other row and display the check image. ex. Upload to imgur option is unavailable for mp4 and webm, it automatically select the option for opening in the file manager.

gort818 added 8 commits September 21, 2018 17:05

Check for file format

0e0fd6b

Checks for file format and deselects imgur upload option for file extentions mp4 and webm as they are not supported through the imgur upload api.

add debug message.

a5ecf1d

If the user used mp4 or webm print a debug message telling them it is not supported for upload to imgur.

Change positon of share dialog window

f2771e3

It now centers on the parent window.

Close the share dialog after uploading image.

abfc727

Fix selection boxes

4265d33

If an option is unavailable automatically select the other row and display the check image. ex. Upload to imgur option is unavailable for mp4 and webm, it automatically select the option for opening in the file manager.

Merge branch 'imgur' of https://github.com/gort818/peek into imgur

fb49937

Add dependencies to meson build system

e5c43b7

Added whitelist for supported upload formats

aacdc10

gort818 added 2 commits September 6, 2019 22:26

Merge https://github.com/phw/peek into imgur

22908f9

fix merge conflicts

ef0480e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Imgur upload functionality #311

Imgur upload functionality #311

gort818 commented Apr 13, 2018

gort818 commented Apr 29, 2018 •

edited

gort818 commented May 2, 2018 •

edited

cocochepeau commented May 6, 2018

gort818 commented May 9, 2018

cocochepeau commented May 11, 2018

gort818 commented May 15, 2018

gort818 commented Jun 7, 2018

gort818 commented Sep 22, 2018

gort818 commented Oct 25, 2018

jcarizza commented Apr 26, 2019

luzpaz commented Sep 4, 2019

gort818 commented Sep 4, 2019

luzpaz commented Sep 5, 2019

gort818 commented Sep 6, 2019

luzpaz commented Sep 7, 2019

luzpaz commented Sep 7, 2019

gort818 commented Sep 7, 2019

luzpaz commented Sep 7, 2019

gort818 commented Sep 7, 2019

luzpaz commented Sep 7, 2019

gort818 commented Sep 7, 2019

luzpaz commented Sep 7, 2019

gort818 commented Sep 17, 2019

luzpaz commented Sep 17, 2019

luzpaz commented Sep 24, 2019

luzpaz commented Oct 11, 2019

Imgur upload functionality #311

Are you sure you want to change the base?

Imgur upload functionality #311

Conversation

gort818 commented Apr 13, 2018

gort818 commented Apr 29, 2018 • edited

gort818 commented May 2, 2018 • edited

cocochepeau commented May 6, 2018

gort818 commented May 9, 2018

cocochepeau commented May 11, 2018

gort818 commented May 15, 2018

gort818 commented Jun 7, 2018

gort818 commented Sep 22, 2018

gort818 commented Oct 25, 2018

jcarizza commented Apr 26, 2019

luzpaz commented Sep 4, 2019

gort818 commented Sep 4, 2019

luzpaz commented Sep 5, 2019

gort818 commented Sep 6, 2019

luzpaz commented Sep 7, 2019

luzpaz commented Sep 7, 2019

gort818 commented Sep 7, 2019

luzpaz commented Sep 7, 2019

gort818 commented Sep 7, 2019

luzpaz commented Sep 7, 2019

gort818 commented Sep 7, 2019

luzpaz commented Sep 7, 2019

gort818 commented Sep 17, 2019

luzpaz commented Sep 17, 2019

luzpaz commented Sep 24, 2019

luzpaz commented Oct 11, 2019

gort818 commented Apr 29, 2018 •

edited

gort818 commented May 2, 2018 •

edited