Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash with clone of Redis object #1789

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

iliaal
Copy link
Contributor

@iliaal iliaal commented Jun 18, 2020

Current clone of redis object results in a crash. This patch fixes the crash and allows a copy of redis object to be created. This is helpful when you want to share same connection but with different settings (i.e. different OPT_PREFIX)

@iliaal
Copy link
Contributor Author

iliaal commented Jul 22, 2020

@michael-grunder @yatsukhnenko Hi guys anyway we can get this into next release. The last issue with auth was resolved. I see one test failing, but seems completely unrelated to the changes and only on 1 clang environment.

@iliaal
Copy link
Contributor Author

iliaal commented Jan 30, 2021

@michael-grunder / @yatsukhnenko Can we please revisit this PR, if there are any concerns I am happy to address them or adjust code as needed, but hoping we could get this in to the next release.

@michael-grunder
Copy link
Member

Hi @iliaal. I'm putting together the 5.3.3 release right now, which just includes two tiny changes for PHP8 compatibility.

I think fixing the segmentation fault on clone is a good idea but would want to hold off on a full clone implementation until a subsequent release where we have release candidates.

@iliaal
Copy link
Contributor Author

iliaal commented Feb 4, 2021

@michael-grunder heh I saw 5.3.3 came out, can we consider this for 5.3.4?

@michael-grunder michael-grunder modified the milestones: 5.3.0, 5.3.4 Feb 4, 2021
@michael-grunder
Copy link
Member

Sure, I'm OK with that. I want to make sure we don't worsen the situation with connection re-use (e.g. going out of sync) but being able to clone the redis object will be a nice convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants