Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adjustments while implementing ACL #84

Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Open

[WIP] adjustments while implementing ACL #84

wants to merge 1 commit into from

Conversation

dbu
Copy link
Member

@dbu dbu commented Feb 10, 2015

Principal is something from java.security, so its not jcr specific at all. meaning there is no infrastructure to build principals.

i guess we either need a factory method on the AccessControlManager or provide the trivial implementation in PHPCR directly so people can use new.

i wonder how the java side of this actually works, if its using all that fancy stuff to in the end do a string comparison because the principal name and the username used in the jackrabbit connection.

@lsmith77
Copy link
Member

I guess removing stuff from the interface is safe

@dbu
Copy link
Member Author

dbu commented Feb 11, 2015 via email

@dbu
Copy link
Member Author

dbu commented Feb 11, 2015

ah, we even have this note, so really no worries: https://github.com/phpcr/phpcr/blob/master/doc/JCR_TO_PHPCR.txt#L310-L311

we should update that documentation when we are good, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants