[ticket/15851] Automatic update downloader #6544
Conversation
PHPBB3-15851
| use phpbb\filesystem\exception\filesystem_exception; | ||
| use phpbb\filesystem\filesystem_interface; | ||
| use SodiumException; | ||
| use ZipArchive; |
There was a problem hiding this comment.
composer should include php-zip as requirement
There is a functions_compress.php in includes folder too that can be used if the server don't have zip installed (or just dont allow updates)
There was a problem hiding this comment.
i doubt that would actually work if this is not working.
| * | ||
| * @return bool Whether the signature is correct or not. | ||
| */ | ||
| public function validate(string $file_path, string $signature_path): bool |
There was a problem hiding this comment.
Please return the reason why the signature is not valid so it's possible to solve the error without having to add debug statements everywhere.
(Download doesn't exist, signature doesn't exist, unable to decode base64, what SodiumException occurred)
There was a problem hiding this comment.
that doesn't really make any sense to me, we only care if the signature is valid or not. Further more, how this is used, it is impossible to not have the file.
PHPBB3-15851
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB3-15851