Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/17135] Introduce Symfony Mailer for emails backend #6483

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

rxu
Copy link
Contributor

@rxu rxu commented May 5, 2023

Checklist:

  • Correct branch: master for new features; 3.3.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.3.x
  • Commit follows commit message format

PHPBB3-17135.

@private-packagist
Copy link

private-packagist bot commented May 5, 2023

phpBB/composer.lock

Package changes

Package Operation From To Changes
doctrine/lexer add - 3.0.0 view code
egulias/email-validator add - 4.0.2 view code
symfony/mailer add - v6.3.5 view code

Settings · Docs · Powered by Private Packagist

@rxu rxu force-pushed the ticket/17135 branch 5 times, most recently from 84d6835 to 941c059 Compare May 12, 2023 13:14
@rxu rxu force-pushed the ticket/17135 branch 3 times, most recently from 34802c9 to 6e5571f Compare May 12, 2023 13:32
@rxu rxu marked this pull request as draft June 7, 2023 17:31
@rxu rxu force-pushed the ticket/17135 branch 11 times, most recently from 80af106 to b3db2b9 Compare June 9, 2023 07:48
@private-packagist
Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

@rxu rxu force-pushed the ticket/17135 branch 3 times, most recently from 74af253 to a1c9c93 Compare July 11, 2023 07:17
@private-packagist
Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

@rxu rxu force-pushed the ticket/17135 branch 2 times, most recently from 5cb9a34 to f04d20c Compare July 11, 2023 07:42
@private-packagist
Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

@rxu rxu marked this pull request as ready for review September 22, 2023 08:05
@rxu
Copy link
Contributor Author

rxu commented Sep 22, 2023

This actually needs some review as it's not clear what's next. In current PR state emailing just works (at least for simple cases).
Also I couldn't find a good way to implement email automated tests as default Symfony instruction relies on using Symfony Recipes / extending FrameworkBundle / extending KernelTestCase which is not used in phpBB test framework.

Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants