$this type inside object creation
#2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work inside btw. on that class this is not the last issue - it's a good implicit test case 😉 |
dantleech
reviewed
Mar 28, 2024
| @@ -34,6 +34,29 @@ public function hello() | |||
| $this->assertEquals(false, $frame->locals()->byName('this')->first()->isProperty()); | |||
| }]; | |||
|
|
|||
| yield 'It returns this with correct type' => [ | |||
There was a problem hiding this comment.
... in an anonymous function
mamazu
changed the title
$this type inside object creation
|
is this a regression or has it never worked? |
|
This is a regression fix. Before adding |
|
In which MR was the regression introduced? |
It's a regression, as I mentioned in #2618 (comment) (this PR should contain |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's an easy fix. If we're inside an
ObjectCreationExpressionand it has a name, then just continue looking up the tree.