Improving support for anonymous classes #2613

mamazu · 2024-03-22T19:54:14Z

Things that have been done

Completion for it works (tests added)
Check if there is a better way to generate the name of the anonymous classes

Limitations:

The current implementation uses the byteoffset of the class. Meaning that the classname could change if there are textedits that change the text before the class
This doesn't go into ClassDeclarationNodes so anoymous classes inside a class wouldn't be recognized?

lib/WorseReflection/Core/Inference/Resolver/ObjectCreationExpressionResolver.php

mamazu · 2024-03-22T19:59:06Z

lib/WorseReflection/Core/Reflection/Collection/ReflectionClassLikeCollection.php

+            }
+
+            if ($child instanceof ObjectCreationExpression) {
+                // TODO: come up with a good way to generate a class name


We need a better way to generate class names as the code is currently duplicated everywhere.

PHPStan does it like this: https://github.com/dantleech/phpstan-src/blob/f7b89d47cfa1fa636fb571b4315841a9af0e976f/src/Broker/AnonymousClassNameHelper.php#L22-L25

but I don't think this is the correct place to do it.

We can create the reflection class in the resolver?

Yeah, technically using the line number is not 100% garanteed to be unique but who has two anon classes on the same line. :D

But what you mean with "creating the reflection class in the resolver"? I wanted to try to avoid making a ReflectionAnonymousClass class as anon classes should be the same except for their weird name.

Yes you are right. A different approach for this would probably make more sense but that would require a lot of refactoring as the fromNode function is used quite a lot.

I don't think it needs refactoring and would also fix the issue Thomas raised below, but would need to show an example.

lib/WorseReflection/Core/Inference/Resolver/ObjectCreationExpressionResolver.php

lib/WorseReflection/Core/Reflection/Collection/ClassLikeReflectionMemberCollection.php

lib/WorseReflection/Core/Inference/Resolver/ObjectCreationExpressionResolver.php

przepompownia · 2024-03-25T22:07:48Z

From #2612 perspective this seems to be one step ahead but:

mamazu · 2024-03-25T22:12:11Z

What were you trying to do? Generate a class?

przepompownia · 2024-03-25T22:13:34Z

"Implement contracts" like in #2612

mamazu · 2024-03-25T23:02:05Z

Now it should work (at least the test for it is green) and it looks like the rest broke.

przepompownia · 2024-03-25T23:23:21Z

Works for me:

lib/WorseReflection/Core/Reflection/Collection/ClassLikeReflectionMemberCollection.php

dantleech · 2024-03-29T09:23:32Z

lib/WorseReflection/Core/Reflection/Collection/ReflectionClassLikeCollection.php

+                continue;
+            }
+
+            if ($child instanceof ObjectCreationExpression && !($child->classTypeDesignator instanceof Node)) {


this may cause unexpected issues. "reflect classes in" reflects locatable symbols and also it should not need to deeply traverse the AST.

we could consider removing this and instead adding support to $reflector->reflect{Node,AnnonymousClass,Object}($node) for example.

The problem is this approach won't find all classes anyways. Because we actually have to traverse into class definitions as well. Otherwise we would miss anonymous classes inside other classes. But I don't have an idea how to do improve performance here.

yes, they need probably to be interpreted inline as types as with the above comment. doing this will mean that "implement contracts" will not automatically work, but at the same time it's only working because of the cache effect in this PR

I just saw that reflectClassesIn should probably better be named reflectClassLikeIn 'cause it also returns interfaces enums etc. which are completely irrelevant for the "Implement contracts". But that's not a problem of this PR.

However I get what you're saying, I'm not sure if its based on cache in this situation because the source code builder reflects the same structure again and should also build the same list of ClassLike nodes. On the other hand I'm quite familiar with the concept of inline types and how I would go about and implement this. Do we already have an example for this?

…s_classes

przepompownia · 2024-04-19T09:49:13Z

At the moment I have no occasion to work with anonymous classes, but have merged the recent version of this PR into my experimental branch and can report possible side effects.

dantleech · 2024-04-19T10:32:56Z

just to be clear, it's unlikely to be merged with it's current implementation. but hopefully I can find some time to look more into it.

First try at implementing it

c597a53

mamazu marked this pull request as draft March 22, 2024 19:54

mamazu changed the title ~~First try at implementing it~~ Improving support for anonymous classes Mar 22, 2024

Fixups

5cc2e4d

mamazu commented Mar 22, 2024

View reviewed changes

This was referenced Mar 22, 2024

Implement contracts inside anonymous classes #2612

Open

Diagnostics error in anonymous class #1320

Open

Anonymous class support #663

Open

mamazu added 3 commits March 23, 2024 00:46

Skip real classes in ObjectCreationExpressions

71bf377

Improvements

f76d62f

Removing unused properties

d98a9f8

dantleech reviewed Mar 23, 2024

View reviewed changes

lib/WorseReflection/Core/Inference/Resolver/ObjectCreationExpressionResolver.php Outdated Show resolved Hide resolved

dantleech reviewed Mar 23, 2024

View reviewed changes

lib/WorseReflection/Core/Reflection/Collection/ClassLikeReflectionMemberCollection.php Outdated Show resolved Hide resolved

Making assertions assert the correct type

5e5389a

dantleech reviewed Mar 23, 2024

View reviewed changes

lib/WorseReflection/Core/Inference/Resolver/ObjectCreationExpressionResolver.php Outdated Show resolved Hide resolved

mamazu added 3 commits March 23, 2024 16:07

Merge branch 'master' into anonymous_classes

4889c1c

Using the reflected class resolver

836d962

Using a softer exception

8e24b48

mamazu force-pushed the anonymous_classes branch from f8c99ee to 8e24b48 Compare March 24, 2024 18:14

mamazu marked this pull request as ready for review March 24, 2024 23:15

More fixup

f32ad1b

mamazu force-pushed the anonymous_classes branch from 4235fc4 to f32ad1b Compare March 24, 2024 23:34

Adding support for extending anonymous classes

7a53a6b

mamazu force-pushed the anonymous_classes branch from 681f9c8 to 7a53a6b Compare March 25, 2024 23:07

Improving the typing

701944a

dantleech reviewed Mar 29, 2024

View reviewed changes

lib/WorseReflection/Core/Reflection/Collection/ClassLikeReflectionMemberCollection.php Outdated Show resolved Hide resolved

dantleech reviewed Mar 29, 2024

View reviewed changes

mamazu added 24 commits March 30, 2024 15:43

Adding an isAnonymous method to the class

8b69ecb

Improving it some more

168f3e2

More sensible default

cbeb726

Adding tests back

07dd87c

First try at implementing it

c79260d

Fixups

f91f1b4

Skip real classes in ObjectCreationExpressions

ae72ace

Improvements

046ff0c

Removing unused properties

f8044f4

Making assertions assert the correct type

10d4180

Using the reflected class resolver

202087e

Using a softer exception

175266d

More fixup

bc3b1b4

Adding support for extending anonymous classes

0ea9d3e

Improving the typing

14802b4

Adding an isAnonymous method to the class

0ea17a9

Improving it some more

f197e6f

More sensible default

e5ff010

Adding tests back

c30b479

Merge remote-tracking branch 'origin/anonymous_classes' into anonymou…

4f76488

…s_classes

Fixing type errors

9249c6a

Reverting changes

6640629

Fix

caa112a

Moving the ReflectionClassLikeCollection creation to the reflector

da577f9

mamazu force-pushed the anonymous_classes branch from b7acb99 to da577f9 Compare April 9, 2024 09:08

Merge branch 'master' into anonymous_classes

011b095

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improving support for anonymous classes #2613

Improving support for anonymous classes #2613

mamazu commented Mar 22, 2024 •

edited

mamazu Mar 22, 2024

dantleech Mar 23, 2024

mamazu Mar 23, 2024

mamazu Mar 24, 2024

dantleech Mar 25, 2024

przepompownia commented Mar 25, 2024

mamazu commented Mar 25, 2024

przepompownia commented Mar 25, 2024

mamazu commented Mar 25, 2024

przepompownia commented Mar 25, 2024

dantleech Mar 29, 2024

mamazu Apr 9, 2024

dantleech Apr 9, 2024 •

edited

mamazu Apr 9, 2024

przepompownia commented Apr 19, 2024 •

edited

dantleech commented Apr 19, 2024

Improving support for anonymous classes #2613

Are you sure you want to change the base?

Improving support for anonymous classes #2613

Conversation

mamazu commented Mar 22, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

przepompownia commented Mar 25, 2024

mamazu commented Mar 25, 2024

przepompownia commented Mar 25, 2024

mamazu commented Mar 25, 2024

przepompownia commented Mar 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dantleech Apr 9, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

przepompownia commented Apr 19, 2024 • edited

dantleech commented Apr 19, 2024

mamazu commented Mar 22, 2024 •

edited

dantleech Apr 9, 2024 •

edited

przepompownia commented Apr 19, 2024 •

edited