Adding more types in the FileFinder

[mamazu]

Todo maybe: This class does a lot of copying with file path arrays maybe it would make more sense to refactor this to either append the arrays or to copy only once with the spread operator.

Either:

$filePaths = [];
$this->parentFilePaths($reflection, $filePaths);
$this->interfaceFilePaths($reflection, $filePaths);

return FileList::fromFilePaths($filePaths);

or:

return FileList::fromFilePaths([
    ...$filePaths,
    ...$this->parentFilePaths($reflection),
    ...$this->interfaceFilePaths($reflection),
]);

[dantleech]

this was array<string|null>? is this definitely not handled? we could also skip if it's NULL for whatever reason.

[mamazu]

Yeah seeing that this never crashes it seems like it's never null but yeah, skipping those would probably be the better option.

[dantleech]

thanks!