Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated composer 1 methods #2605

Merged
merged 3 commits into from Mar 23, 2024
Merged

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Mar 17, 2024

  • Explicitly documenting composer 2 as a dependency (as we already use the InstalledVersions class in the project somewhere else
  • Replacing PackageVersions\Version with the not deprecated version.

README.md Outdated
@@ -30,7 +30,7 @@ Requirements
------------

- PHP 8.1+
- [Composer](https://getcomposer.org/)
- [Composer 2](https://getcomposer.org/)
Copy link
Collaborator

@dantleech dantleech Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we need to specify 2, you need composer. nobody should be using v1. pretty sure it;ll conflict if trying to install with 1 anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Removed.

@dantleech dantleech merged commit 6f4c98e into phpactor:master Mar 23, 2024
10 checks passed
@dantleech
Copy link
Collaborator

🙇

@mamazu mamazu deleted the composer_2 branch March 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants