Gh 2538: Disable include walker #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
gh-2538-disable-include-walker
branch
from
39b284e
to
702f30d
Compare
dantleech
force-pushed
the
gh-2538-disable-include-walker
branch
from
702f30d
to
f263b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the contributing factores to #2438 is the include walker, which can cause a 3-5x performance penalty in certain projects.
When investigating this I noticed that it doesn't actually seem to work, at least as far as completion is concerned, and I don't want to burn more time on this so I'm just removing this functionaltiy for now.
If anybody was using this successfully we can consider ways to optimise it and include it again, but as I can't actually see any benefits in keeping it right now I'm removing it.