Make the use of POSIX signals optional (#2569)

Signals are not supported on Windows, and gracefully shutting down everything doesn't seem necessary if we're about to exit anyway.
phpactor · Mar 2, 2024 · 12996ed · 12996ed
1 parent 09605ad
commit 12996ed
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/composer.json b/composer.json
@@ -4,8 +4,6 @@
     "license": "MIT",
     "require": {
         "php": "^8.1",
-        "ext-pcntl": "*",
-        "ext-posix": "*",
         "composer/package-versions-deprecated": "^1.0",
         "composer/xdebug-handler": "^3.0",
         "symfony/yaml": "^5.1",

diff --git a/composer.lock b/composer.lock
diff --git a/lib/Indexer/Extension/Command/IndexBuildCommand.php b/lib/Indexer/Extension/Command/IndexBuildCommand.php
@@ -106,12 +106,15 @@ private function watch(OutputInterface $output): void
         Loop::run(function () use ($output) {
             $process = yield $this->watcher->watch();
 
-            Loop::onSignal(SIGINT, function () use ($output, $process): void {
-                $output->write('Shutting down watchers...');
-                $process->stop();
-                $output->writeln('done');
-                Loop::stop();
-            });
+            // Signals are not supported on Windows
+            if(defined('SIGINT')) {
+                Loop::onSignal(SIGINT, function () use ($output, $process): void {
+                    $output->write('Shutting down watchers...');
+                    $process->stop();
+                    $output->writeln('done');
+                    Loop::stop();
+                });
+            }
 
             $output->writeln(sprintf('<info>Watching for file changes with </>%s<info>...</>', $this->watcher->describe()));