Paths containing special characters paths in the configuration are wrongly resolved #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvriel
commented
Jul 24, 2022
| @@ -8,6 +8,7 @@ | |||
| <title>phpDocumentor</title> | |||
| <paths> | |||
| <output>build/website/docs</output> | |||
| <cache>build/ex$a#mple cache/</cache> | |||
There was a problem hiding this comment.
Don't forget to remove this before submitting as a definitive PR :D
Signed-off-by: Mike van Riel <me@mikevanriel.com>
Signed-off-by: Mike van Riel <me@mikevanriel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3184 and related tickets for the original report.
When using special characters, these are URL encoded and phpDocumentor is unable to process this. What needs to be done is that phpDocumentor is able to support physical and virtual filesystems (through the DSN) and know when to URL encode and when not. Some virtual file systems may require this.
Part of the solution in this PR requires investigating when and if we should or should not URL encode