Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side validation of form-user #695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cmb69
Copy link
Contributor

@cmb69 cmb69 commented Sep 6, 2022

That is supposed to be an email address, and the client side validation
will at least help legitimate users (and maybe reduce some nonsense).

That is supposed to be an email address, and the client side validation
will at least help legitimate users (and maybe reduce some nonsense).
@salathe
Copy link
Contributor

salathe commented Sep 6, 2022

That is supposed to be an email address...

If that's the case, maybe change the label (currently "Your email address (or name):") as well, and the server-side validation.
If it's not the case (i.e. can be email or a plain name), thumbs down on this change.

@cmb69
Copy link
Contributor Author

cmb69 commented Sep 6, 2022

Ah, good catch, @salathe! The point is that a user can enter a name only, but the notification mails then show USERNAME@mail.php.net as sender (e.g. https://news-web.php.net/php.notes/219540). This is confusing for readers, and it makes it impossible to reject user notes (so they need to be deleted). If we can change the behavior of the mail server, I'm okay-ish with asking for username or email address (although that still would cause deletions instead of rejections).

Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants