-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window API will return Window Rect #804
Open
oleg-andreyev
wants to merge
4
commits into
php-webdriver:main
Choose a base branch
from
oleg-andreyev:window-api-resuts-window-dimension-object
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Window API will return Window Rect #804
oleg-andreyev
wants to merge
4
commits into
php-webdriver:main
from
oleg-andreyev:window-api-resuts-window-dimension-object
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Jun 23, 2020
oleg-andreyev
force-pushed
the
window-api-resuts-window-dimension-object
branch
from
June 23, 2020 22:17
03d86e3
to
f0b65fb
Compare
oleg-andreyev
force-pushed
the
window-api-resuts-window-dimension-object
branch
from
March 14, 2021 15:49
f0b65fb
to
2816cf6
Compare
williamdes
suggested changes
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds BC breaks, maybe -> v2
Yes, I think this was discussed with @OndraM in PR comments |
williamdes
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
…window rect, which could be useful for consumers
oleg-andreyev
force-pushed
the
window-api-resuts-window-dimension-object
branch
from
March 20, 2021 22:28
b670d2a
to
f37e591
Compare
williamdes
reviewed
Mar 21, 2021
@OndraM please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on specifications Window API, window size manipulation returns window rect, which could be useful for consumers
Ref.:
Because it's an API change, it can only go into the main branch and major version release.
To Do: