Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle raw_data better in Entity class #1399

Merged
merged 1 commit into from May 7, 2023
Merged

Handle raw_data better in Entity class #1399

merged 1 commit into from May 7, 2023

Conversation

noplanman
Copy link
Member

? !
Type improvement
BC Break no
Fixed issues n/a

Summary

Better handling of the raw_data property, moving it to a dedicated property instead of sharing the main data array.

@noplanman noplanman requested a review from TiiFuchs May 7, 2023 19:54
TiiFuchs
TiiFuchs approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@TiiFuchs TiiFuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. We should test it quite thoroughly though.

@noplanman noplanman merged commit 7e419ed into develop May 7, 2023
0 of 6 checks passed
@noplanman noplanman deleted the improve-entity-data-handling branch May 7, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiiFuchs TiiFuchs TiiFuchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noplanman @TiiFuchs