Feat: allow dynamic properties for PHP8.2 #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `AllowDynamicProperties` attribute to Entities.php for PHP8.2 compatibility. Not a permanent/final solution, but good enough to allow upgrades.
|
@TiiFuchs Happy to do this for now? |
|
Yeah we had this coming. Need to add |
|
(Those checks are not very useful at all at the moment 😞) |
|
For the record I'l cross-reference this issue in which we discussed this topic before: #1375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
AllowDynamicPropertiesattribute to Entities.php for PHP8.2 compatibility. Not a permanent/final solution, but good enough to allow upgrades.#1375