Make nullable parameter types explicit #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Mar 15, 2024
| @@ -18,7 +18,7 @@ public function __construct(ResponseInterface $response) | |||
| $this->response = $response; | |||
| } | |||
|
|
|||
| public function then(callable $onFulfilled = null, callable $onRejected = null) | |||
| public function then(?callable $onFulfilled = null, ?callable $onRejected = null) | |||
There was a problem hiding this comment.
can we do this without the interface changing? if not, this bumps the minimum requirement of promise to the version that will contains php-http/promise#34
There was a problem hiding this comment.
can we do this without the interface changing?
Yes, this is a purely syntactical change.
It's not, even if people extended the classes. This change doesn't break anything. |
|
thanks a lot! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR turns implicit nullable parameter types to explicit ones.
Why?
PHP allows to implicitly declare a nullable parameter type by setting the parameter's default value to
null. However, in PHP 8.4 this syntax has been deprecated.https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
see also php-http/promise#34