Merge pull request #174 from php-http/promise-cleanup

cleanup promise phpdoc
php-http · Jan 4, 2024 · 074c34a · 074c34a
2 parents 625ad74 + be85672
commit 074c34a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 21 deletions.
diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml
@@ -15,6 +15,9 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v3
 
+      - name: Remove phpspec
+        run: composer remove --dev friends-of-phpspec/phpspec-code-coverage phpspec/phpspec
+
       - name: PHPStan
         uses: docker://oskarstark/phpstan-ga
         with:

diff --git a/src/Exception/RequestAwareTrait.php b/src/Exception/RequestAwareTrait.php
@@ -16,9 +16,6 @@ private function setRequest(RequestInterface $request)
         $this->request = $request;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getRequest(): RequestInterface
     {
         return $this->request;

diff --git a/src/Promise/HttpFulfilledPromise.php b/src/Promise/HttpFulfilledPromise.php
@@ -18,9 +18,6 @@ public function __construct(ResponseInterface $response)
         $this->response = $response;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function then(callable $onFulfilled = null, callable $onRejected = null)
     {
         if (null === $onFulfilled) {
@@ -34,17 +31,11 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getState()
     {
         return Promise::FULFILLED;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function wait($unwrap = true)
     {
         if ($unwrap) {

diff --git a/src/Promise/HttpRejectedPromise.php b/src/Promise/HttpRejectedPromise.php
@@ -17,9 +17,6 @@ public function __construct(Exception $exception)
         $this->exception = $exception;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function then(callable $onFulfilled = null, callable $onRejected = null)
     {
         if (null === $onRejected) {
@@ -38,17 +35,11 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getState()
     {
         return Promise::REJECTED;
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function wait($unwrap = true)
     {
         if ($unwrap) {