Add handling for compound types. #45
Conversation
| function veryComplex( | ||
| array | ||
| |(ArrayAccess&Traversable) | ||
| |(Traversable&Countable) $input): ArrayAccess&Traversable |
There was a problem hiding this comment.
| |(Traversable&Countable) $input): ArrayAccess&Traversable | |
| |(Traversable&Countable) $input | |
| ): ArrayAccess&Traversable |
There was a problem hiding this comment.
Hm. Not sure here. Does this context also force multilining the return part? If so, that should be said explicitly somewhere.
There was a problem hiding this comment.
Yeah doing this would split the argument list over multiple lines and would make "argument list is split across multiple lines" rules apply here. I get that this is different than actually splitting each argument onto their own lines but I don't think that distinction matters at all when it comes to readability and consistency.
| that all compound types be structured as an ORed (unioned) series of ANDs (intersections), and that each set of | ||
| intersections be encased with parentheses. | ||
|
|
||
| The union symbol `|` and intersection symbol `&` MUST NOT have a leading or trailing space. The parentheses MUST NOT |
There was a problem hiding this comment.
While I personally agree that there should be no spaces around the "symbols", this appears to be inconsistent with catch() which has spaces around in the example:
Line 967 in b49fd56
There was a problem hiding this comment.
That should be unified one way or another 👍
|
I think the catch consistency question is a big one so I've opened a vote in discord for the WG to decide the way to move forward. |
There's likely to be discussion on this, but this PR gets us started. Discuss.