Add phpDoc for objects using phpwaver #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add phpDoc to some of the code in pts-core/objects, the types where determined by running debug-self-test through phpweaver for a few secounds and then manually verityfing the result.
|
@michaellarabel I saw you recent article about PHPStan 1.0 and you using it a lot. Considering that the intent with this PR was to get better analysis from PHPStan by providing it with richer type information I would think you would be interested in it. But since you still haven't reviewed it after 2 years I'm starting to wonder if I should just close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add phpDoc to some of the code in pts-core/objects, the types where
determined by running debug-self-test through phpweaver for a few
secounds and then manually verityfing the result.
phpDoc can be helpful as documentation, but also for auto-completion in editors and for finding bugs, and as a guide for refactoring.
There is a lot more that can be added, but I thought this was good as an ice breaker to see how you felt about it.