Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc improvement] Fix dead links, adjust link names #3241

Merged
merged 4 commits into from May 15, 2024

Conversation

c4710n
Copy link
Contributor

@c4710n c4710n commented May 11, 2024

This PR:

  • fix dead links of dom patching related docs
  • adjust link names in Welcome.md to match the ones in sidebar
  • fix ex_doc warnings - warning: :groups_for_functions is deprecated, please use :groups_for_docs instead
  • sync link name of uploads-external.md

Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution 💜
I love how the docs keep getting better!

guides/cheatsheets/html-attrs.cheatmd Show resolved Hide resolved
guides/introduction/welcome.md Show resolved Hide resolved
guides/introduction/welcome.md Outdated Show resolved Hide resolved
guides/introduction/welcome.md Outdated Show resolved Hide resolved
guides/client/uploads-external.md Outdated Show resolved Hide resolved
@c4710n c4710n force-pushed the zd/improve-doc-1 branch 2 times, most recently from 96e7e51 to 69c838a Compare May 15, 2024 12:26
@SteffenDE SteffenDE merged commit 6ce0613 into phoenixframework:main May 15, 2024
6 checks passed
@SteffenDE
Copy link
Collaborator

Very nice! Thank you 🙌

@c4710n c4710n deleted the zd/improve-doc-1 branch May 16, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants