Doc update for Phoenix.LiveView.stream_insert/4
#3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhcarvalho
reviewed
May 15, 2024
There was a problem hiding this comment.
Thanks! I think this is in the right direction :)
I found a change in 69cea0c thanks to the changelog for 0.20.4, so @SteffenDE might remember how it is supposed to be! The changelong reads:
Bug fixes
...
- Never move existing stream items if they already exist (use
stream_deleteand thenstream_insertinstead)
|
The change is good, thank you 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs to make it clear that in the case where the item already exists in the parent DOM container, it's position will not be changed regardless of the value of the
:atoption. In particular, I removed the phrase, "while also moving it to the top of the collection", which was inaccurate.