Introduce tracking of used and unused inputs with error message filtering #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
Merged
josevalim
reviewed
Feb 5, 2024
krns
reviewed
Feb 5, 2024
josevalim
reviewed
Feb 7, 2024
Co-authored-by: Simon Hansen <simon@kerns.sh>
chrismccord
force-pushed
the
cm-used-errors
branch
from
dc7367c
to
ac948ba
Compare
SteffenDE
reviewed
May 3, 2024
| let liveSocket = new window.LiveView.LiveSocket("/live", window.Phoenix.Socket, {params: {_csrf_token: csrfToken}}) | ||
| let liveSocket = new window.LiveView.LiveSocket("/live", window.Phoenix.Socket, { | ||
| params: {_csrf_token: csrfToken}, | ||
| dom: phxFeedbackDom({}) |
There was a problem hiding this comment.
should we maybe only add this to a custom layout specifically for the /form/feedback page?
There was a problem hiding this comment.
Ideally yes, but I wasn't positive where to configure that
SteffenDE
added a commit
to SteffenDE/phoenix_live_view
that referenced
this pull request
May 15, 2024
…ge filtering (phoenixframework#3090)" This reverts commit d912468.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required releases:
phoenix_htmlAdd form action and consider input changed if action changes phoenix_html#439phoenix_ectoUse to_form :action as changeset action when passed phoenix_ecto#171